Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 12089068: Revert 179554 - suspected to break browser_tests on Mac 10.6 (Closed)

Created:
7 years, 10 months ago by kinuko
Modified:
7 years, 10 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Revert 179554 - suspected to break browser_tests on Mac 10.6 > Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome. > > Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms. > > Depends on https://codereview.chromium.org/12018007/ > > BUG=169138 > > Review URL: https://chromiumcodereview.appspot.com/11896104 TBR=scheib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -108 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 3 chunks +1 line, -9 lines 0 comments Download
D chrome/browser/ui/browser_commands_mac.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/browser_commands_mac.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.h View 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 9 chunks +65 lines, -48 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
7 years, 10 months ago (2013-01-30 12:28:59 UTC) #1
kinuko
Mac 10.6 bot is consistently having CHECK error here: [2238:263:0130/035234:4049296547214:FATAL:fullscreen_controller.cc(535)] Check failed: base::mac::IsOSLionOrLater(). Let me ...
7 years, 10 months ago (2013-01-30 12:29:58 UTC) #2
kinuko
Hmm this doesn't fix. Probably I should revert this revert or go on to try ...
7 years, 10 months ago (2013-01-30 13:28:56 UTC) #3
kinuko
7 years, 10 months ago (2013-01-30 13:29:43 UTC) #4
Ok, I'll revert this revert as the bot is not a closer. Hope you can fix
the issue when you see this mail.

The crash log:
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg...


On Wed, Jan 30, 2013 at 10:28 PM, Kinuko Yasuda <kinuko@chromium.org> wrote:

> Hmm this doesn't fix.  Probably I should revert this revert or go on to
> try reverting r179399...
>
>
> On Wed, Jan 30, 2013 at 9:29 PM, <kinuko@chromium.org> wrote:
>
>> Mac 10.6 bot is consistently having CHECK error here:
>>
>> [2238:263:0130/035234:**4049296547214:FATAL:**fullscreen_controller.cc(535)]
>> Check
>> failed: base::mac::IsOSLionOrLater().
>>
>> Let me try reverting this to see if it fixes. (If it was a false positive
>> I'll
>> revert this revert)
>>
>>
https://codereview.chromium.**org/12089068/<https://codereview.chromium.org/1...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698