Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js

Issue 12096024: Add validation to length, packets and packetLength parameters (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/usb/usb_device.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var usb = chrome.usb; 5 var usb = chrome.usb;
6 6
7 var genericTransfer = { 7 var genericTransfer = {
8 "direction": "in", 8 "direction": "in",
9 "endpoint": 1, 9 "endpoint": 1,
10 "length": -1 10 "length": -1
11 }; 11 };
12 var controlTransfer = { 12 var controlTransfer = {
13 "index": 0, 13 "index": 0,
14 "direction": "in", 14 "direction": "in",
15 "requestType": "standard", 15 "requestType": "standard",
16 "recipient": "device", 16 "recipient": "device",
17 "request": 0, 17 "request": 0,
18 "value": 0, 18 "value": 0,
19 "length": -1 19 "length": -1
20 }; 20 };
21 var isoTransfer = { 21 var isoTransfer = {
22 "packetLength": 0, 22 "packetLength": 0,
23 "transferInfo": genericTransfer, 23 "transferInfo": genericTransfer,
24 "packets": 0 24 "packets": 0
25 }; 25 };
26 var errorMessage = 'Transfer length must be a ' + 26 var errorTransferLength = 'Transfer length must be a ' +
27 'positive number less than 104,857,600.'; 27 'positive number less than 104,857,600.';
28 var errorNumPackets = 'Number of packets must be a ' +
29 'positive number less than 4,194,304.';
30 var errorPacketLength = 'Packet length must be a ' +
31 'positive number less than 65,536.';
32 var errorInsufficientTransferLength = 'Transfer length is insufficient.';
28 var largeSize = 100 * 1024 * 1024 + 1; 33 var largeSize = 100 * 1024 * 1024 + 1;
34 var maxPackets = 4 * 1024 * 1024;
35 var maxPacketLength = 64 * 1024;
29 36
30 function createInvalidTransferTest(usbFunction, transferInfo, transferLength) { 37 function createInvalidTransferTest(usbFunction, transferInfo, transferLength) {
31 return function() { 38 return function() {
32 genericTransfer["length"] = transferLength; 39 genericTransfer["length"] = transferLength;
33 controlTransfer["length"] = transferLength; 40 controlTransfer["length"] = transferLength;
34 usb.findDevices({vendorId: 0, productId: 0}, function(devices) { 41 usb.findDevices({vendorId: 0, productId: 0}, function(devices) {
35 var device = devices[0]; 42 var device = devices[0];
36 usbFunction(device, transferInfo, chrome.test.callbackFail( 43 usbFunction(device, transferInfo, chrome.test.callbackFail(
37 errorMessage, function() {})); 44 errorTransferLength, function() {}));
45 });
46 };
47 }
48
49 function createInvalidPacketLengthTest(
50 transferLength, packets, packetLength, errorMessage) {
51 return function() {
52 genericTransfer["length"] = transferLength;
53 isoTransfer["packets"] = packets;
54 isoTransfer["packetLength"] = packetLength;
55 usb.findDevices({vendorId: 0, productId: 0}, function(devices) {
56 var device = devices[0];
57 usb.isochronousTransfer(device, isoTransfer,
58 chrome.test.callbackFail(
59 errorMessage, function() {}));
38 }); 60 });
39 }; 61 };
40 } 62 }
41 63
42 var tests = [ 64 var tests = [
43 createInvalidTransferTest(usb.bulkTransfer, genericTransfer, -1), 65 createInvalidTransferTest(usb.bulkTransfer, genericTransfer, -1),
44 createInvalidTransferTest(usb.controlTransfer, controlTransfer, -1), 66 createInvalidTransferTest(usb.controlTransfer, controlTransfer, -1),
45 createInvalidTransferTest(usb.interruptTransfer, genericTransfer, -1), 67 createInvalidTransferTest(usb.interruptTransfer, genericTransfer, -1),
46 createInvalidTransferTest(usb.isochronousTransfer, isoTransfer, -1), 68 createInvalidTransferTest(usb.isochronousTransfer, isoTransfer, -1),
47 createInvalidTransferTest(usb.bulkTransfer, genericTransfer, largeSize), 69 createInvalidTransferTest(usb.bulkTransfer, genericTransfer, largeSize),
48 createInvalidTransferTest(usb.controlTransfer, controlTransfer, largeSize), 70 createInvalidTransferTest(usb.controlTransfer, controlTransfer, largeSize),
49 createInvalidTransferTest(usb.interruptTransfer, genericTransfer, largeSize), 71 createInvalidTransferTest(usb.interruptTransfer, genericTransfer, largeSize),
50 createInvalidTransferTest(usb.isochronousTransfer, isoTransfer, largeSize) 72 createInvalidTransferTest(usb.isochronousTransfer, isoTransfer, largeSize),
73
74 createInvalidPacketLengthTest(1024, -1, 0, errorNumPackets),
75 createInvalidPacketLengthTest(maxPackets, maxPackets, 0, errorNumPackets),
76 createInvalidPacketLengthTest(1024, 100, -1, errorPacketLength),
77 createInvalidPacketLengthTest(1024, 100, maxPacketLength, errorPacketLength),
78 createInvalidPacketLengthTest(1024, 1025, 0, errorInsufficientTransferLength)
51 ]; 79 ];
52 80
53 chrome.test.runTests(tests); 81 chrome.test.runTests(tests);
OLDNEW
« no previous file with comments | « chrome/browser/usb/usb_device.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698