Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 12096024: Add validation to length, packets and packetLength parameters (Closed)

Created:
7 years, 10 months ago by meacer
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Add validation to length, packets and packet_length parameters of the Usb Api. Parameter limits are determined from the following: packets: 4MB from http://msdn.microsoft.com/en-us/library/windows/hardware/ff538112(v=vs.85).aspx packet_length: 65k since wMaxPacketSize is 16bit integer: http://msdn.microsoft.com/en-us/library/ee437177.aspx BUG=169765 R=gdk@chromium.org,miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182128

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M chrome/browser/extensions/api/usb/usb_api.cc View 1 4 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/usb/usb_device.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js View 1 3 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
meacer
7 years, 10 months ago (2013-01-28 20:52:07 UTC) #1
miket_OOO
lgtm https://codereview.chromium.org/12096024/diff/1/chrome/browser/extensions/api/usb/usb_api.cc File chrome/browser/extensions/api/usb/usb_api.cc (right): https://codereview.chromium.org/12096024/diff/1/chrome/browser/extensions/api/usb/usb_api.cc#newcode646 chrome/browser/extensions/api/usb/usb_api.cc:646: unsigned int packets = transfer.packets; Would a size_t ...
7 years, 10 months ago (2013-01-28 21:23:40 UTC) #2
meacer
https://codereview.chromium.org/12096024/diff/1/chrome/browser/extensions/api/usb/usb_api.cc File chrome/browser/extensions/api/usb/usb_api.cc (right): https://codereview.chromium.org/12096024/diff/1/chrome/browser/extensions/api/usb/usb_api.cc#newcode646 chrome/browser/extensions/api/usb/usb_api.cc:646: unsigned int packets = transfer.packets; On 2013/01/28 21:23:40, miket ...
7 years, 10 months ago (2013-01-28 21:26:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/12096024/1
7 years, 10 months ago (2013-01-28 23:46:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 12096024-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-01-28 23:46:15 UTC) #5
Mustafa Acer
+bryeung for OWNERS review
7 years, 10 months ago (2013-01-28 23:48:31 UTC) #6
Garret Kelly
LGTM
7 years, 10 months ago (2013-01-29 14:48:00 UTC) #7
Garret Kelly
Sorry, I thought I was on this for informational purposes.
7 years, 10 months ago (2013-01-29 14:48:44 UTC) #8
bryeung
lgtm
7 years, 10 months ago (2013-01-29 14:54:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/12096024/1
7 years, 10 months ago (2013-01-29 18:01:34 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 18:49:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/12096024/15001
7 years, 10 months ago (2013-02-13 00:52:36 UTC) #12
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 06:06:08 UTC) #13
Message was sent while issue was closed.
Change committed as 182128

Powered by Google App Engine
This is Rietveld 408576698