Media Galleries: Keep media gallery permission dialogs in sync with the gallery

chrome/browser/media_gallery/media_galleries_preferences.h

Index: chrome/browser/media_gallery/media_galleries_preferences.h
===================================================================
--- chrome/browser/media_gallery/media_galleries_preferences.h	(revision 181441)
+++ chrome/browser/media_gallery/media_galleries_preferences.h	(working copy)
@@ -78,7 +78,8 @@
  public:
   class GalleryChangeObserver {
     public:
-     virtual void OnGalleryChanged(MediaGalleriesPreferences* pref) {}
+     virtual void OnGalleryChanged(MediaGalleriesPreferences* pref,

[vandebo (ex-Chrome), 2013/02/08 19:57:41]

nit: add comment about empty string when the change isn't extension specific.

[Greg Billock, 2013/02/08 20:09:25]

Should this pass any information about which gallery changed? Or it's expected
the client will do a full rescan? In that case, do we really need to pass the
extension id?

[Lei Zhang, 2013/02/08 21:02:12]

It's expecting the client to do a rescan. The situation where having a non-empty
|extension_id| is useful is when:

- extension A and extension B both have permission dialogs open.
- the permission for a gallery in extension A changes.
- checking the extension id allows the dialog controller for extension B to
avoid doing any work.

It could be argued that this is fairly rare, and we don't need the extension id
as an optimization.

[Lei Zhang, 2013/02/09 00:07:43]

Done.

+                                   const std::string& extension_id) {}
 
     protected:
      virtual ~GalleryChangeObserver();
@@ -158,7 +159,7 @@
   void InitFromPrefs(bool notify_observers);
 
   // Notifies |gallery_change_observers_| about changes in |known_galleries_|.
-  void NotifyChangeObservers();
+  void NotifyChangeObservers(const std::string& extension_id);
 
   extensions::ExtensionPrefs* GetExtensionPrefs() const;