Media Galleries: Keep media gallery permission dialogs in sync with the gallery

chrome/browser/media_gallery/media_galleries_preferences.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_GALLERY_MEDIA_GALLERIES_PREFERENCES_H_
 #define CHROME_BROWSER_MEDIA_GALLERY_MEDIA_GALLERIES_PREFERENCES_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 60 matching lines @@
 typedef std::map<MediaGalleryPrefId, MediaGalleryPrefInfo>
     MediaGalleriesPrefInfoMap;
 typedef std::set<MediaGalleryPrefId> MediaGalleryPrefIdSet;
 
 // A class to manage the media gallery preferences.  There is one instance per
 // user profile.
 class MediaGalleriesPreferences : public ProfileKeyedService {
  public:
   class GalleryChangeObserver {
     public:
-     virtual void OnGalleryChanged(MediaGalleriesPreferences* pref) {}
+     virtual void OnGalleryChanged(MediaGalleriesPreferences* pref,

[vandebo (ex-Chrome), 2013/02/08 19:57:41]

nit: add comment about empty string when the change isn't extension specific.

[Greg Billock, 2013/02/08 20:09:25]

Should this pass any information about which gallery changed? Or it's expected
the client will do a full rescan? In that case, do we really need to pass the
extension id?

[Lei Zhang, 2013/02/08 21:02:12]

It's expecting the client to do a rescan. The situation where having a non-empty
|extension_id| is useful is when:

- extension A and extension B both have permission dialogs open.
- the permission for a gallery in extension A changes.
- checking the extension id allows the dialog controller for extension B to
avoid doing any work.

It could be argued that this is fairly rare, and we don't need the extension id
as an optimization.

[Lei Zhang, 2013/02/09 00:07:43]

Done.

+                                   const std::string& extension_id) {}
 
     protected:
      virtual ~GalleryChangeObserver();
   };
 
   explicit MediaGalleriesPreferences(Profile* profile);
   virtual ~MediaGalleriesPreferences();
 
   void AddGalleryChangeObserver(GalleryChangeObserver* observer);
   void RemoveGalleryChangeObserver(GalleryChangeObserver* observer);
@@ skipping 59 matching lines @@
       DeviceIdPrefIdsMap;
 
   // Populates the default galleries if this is a fresh profile.
   void AddDefaultGalleriesIfFreshProfile();
 
   // Builds |known_galleries_| from the persistent store.
   // Notifies GalleryChangeObservers if |notify_observers| is true.
   void InitFromPrefs(bool notify_observers);
 
   // Notifies |gallery_change_observers_| about changes in |known_galleries_|.
-  void NotifyChangeObservers();
+  void NotifyChangeObservers(const std::string& extension_id);
 
   extensions::ExtensionPrefs* GetExtensionPrefs() const;
 
   // The profile that owns |this|.
   Profile* profile_;
 
   // An in-memory cache of known galleries.
   MediaGalleriesPrefInfoMap known_galleries_;
 
   // A mapping from device id to the set of gallery pref ids on that device.
   // All pref ids in |device_map_| are also in |known_galleries_|.
   DeviceIdPrefIdsMap device_map_;
 
   ObserverList<GalleryChangeObserver> gallery_change_observers_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaGalleriesPreferences);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_MEDIA_GALLERY_MEDIA_GALLERIES_PREFERENCES_H_