Allow platform apps to add themselves to the Action Box.

chrome/common/extensions/api/page_launcher.idl

Index: chrome/common/extensions/api/page_launcher.idl
diff --git a/chrome/common/extensions/api/page_launcher.idl b/chrome/common/extensions/api/page_launcher.idl
new file mode 100644
index 0000000000000000000000000000000000000000..664628fa4484046e8d03c7797578f6a257cdf7cc
--- /dev/null
+++ b/chrome/common/extensions/api/page_launcher.idl
@@ -0,0 +1,23 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+

[not at google - send to devlin, 2013/02/01 16:39:47]

API-level description

[Rune Fevang, 2013/02/01 22:12:54]

I added some documentation. I can't find anything in any of the other .idl files
to use as a reference, so please let me know if you had something else in mind.

+namespace pageLauncher {
+  dictionary PageData {

[not at google - send to devlin, 2013/02/01 16:39:47]

Description of PageData

[Rune Fevang, 2013/02/01 22:12:54]

Done.

+    // The url of the page.
+    DOMString url;
+    // The mimetype of the page.
+    DOMString mimetype;
+    // The title of the page, if it has one.
+    DOMString? page_title;
+    // The text that was selected on the page when the event fired.
+    DOMString? selected_text;
+  };

[not at google - send to devlin, 2013/02/01 16:39:47]

I know we're not using tabs.Tab here explicitly, but I think it would actually
be a good thing to do at some point, or at least something like it.

Two things to note: there is a precedent for this (chrome.runtime) but it won't
actually work (bug that I hope to fix sometime) - and I think that fixing this
bug will involve figuring out a standard way to expose tabs to apps (maybe via
an abstraction like PageData) since I doubt this will be the only apps API that
will end up needing it.

Point being: we should make these fields match up with the tabs.Tab names. See
http://developer.chrome.com/extensions/tabs.html#type-Tab but in summary, just:

page_title -> title
selected_text -> selectionText (to match the context menus API - and yeah, use
camel case for things in these APIs)

Also it'd be good to add a comment like "Note: if adding properties to this then
make sure they're compatible with tabs.Tab" but I think that might get pulled in
as a documentation comment, so, never mind...

[Rune Fevang, 2013/02/01 22:12:54]

Done.

+
+  interface Events {
+    // Fired when the user clicks the page launcher entry in the action box.
+    // |pageData| : The details of the page the user was on when the button

[not at google - send to devlin, 2013/02/01 16:39:47]

other IDLs I've seen don't have a space between the | and the :. I only mention
this because I want to check that the IDL parser can figure out that this is the
documentation.

TBH I doubt you'd notice until you enable documentation for the API, but best to
avoid surprises then...

[Rune Fevang, 2013/02/01 22:12:54]

I just opened 6 random .idl files and only one of them omitted the space. I
don't mind changing it, but it seems like this is at least not abnormal.

[not at google - send to devlin, 2013/02/01 22:17:11]

I guess I opened the wrong random IDL file.

+    // was clicked.
+    static void onClicked(PageData pageData);
+  };
+};