chrome/common/extensions/api/page_launcher.idl - Issue 12095023: Allow platform apps to add themselves to the Action Box.

Side by Side Diff: chrome/common/extensions/api/page_launcher.idl

Issue 12095023: Allow platform apps to add themselves to the Action Box. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/action_box_menu.cc ('K') | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | chrome/common/extensions/api/page_launcher/page_launcher_handler.h » ('j') | chrome/common/extensions/api/page_launcher/page_launcher_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	not at google - send to devlin 2013/02/01 16:39:47 API-level description API-level description Rune Fevang 2013/02/01 22:12:54 I added some documentation. I can't find anything Show quoted text On 2013/02/01 16:39:47, kalman wrote: > API-level description I added some documentation. I can't find anything in any of the other .idl files to use as a reference, so please let me know if you had something else in mind.
	5 namespace pageLauncher {

	6 dictionary PageData {
	not at google - send to devlin 2013/02/01 16:39:47 Description of PageData Description of PageData Rune Fevang 2013/02/01 22:12:54 Done. Show quoted text On 2013/02/01 16:39:47, kalman wrote: > Description of PageData Done.
	7 // The url of the page.

	8 DOMString url;

	9 // The mimetype of the page.

	10 DOMString mimetype;

	11 // The title of the page, if it has one.

	12 DOMString? page_title;

	13 // The text that was selected on the page when the event fired.

	14 DOMString? selected_text;

	15 };
	not at google - send to devlin 2013/02/01 16:39:47 I know we're not using tabs.Tab here explicitly, b I know we're not using tabs.Tab here explicitly, but I think it would actually be a good thing to do at some point, or at least something like it. Two things to note: there is a precedent for this (chrome.runtime) but it won't actually work (bug that I hope to fix sometime) - and I think that fixing this bug will involve figuring out a standard way to expose tabs to apps (maybe via an abstraction like PageData) since I doubt this will be the only apps API that will end up needing it. Point being: we should make these fields match up with the tabs.Tab names. See http://developer.chrome.com/extensions/tabs.html#type-Tab but in summary, just: page_title -> title selected_text -> selectionText (to match the context menus API - and yeah, use camel case for things in these APIs) Also it'd be good to add a comment like "Note: if adding properties to this then make sure they're compatible with tabs.Tab" but I think that might get pulled in as a documentation comment, so, never mind... Rune Fevang 2013/02/01 22:12:54 Done. Show quoted text On 2013/02/01 16:39:47, kalman wrote: > I know we're not using tabs.Tab here explicitly, but I think it would actually > be a good thing to do at some point, or at least something like it. > > Two things to note: there is a precedent for this (chrome.runtime) but it won't > actually work (bug that I hope to fix sometime) - and I think that fixing this > bug will involve figuring out a standard way to expose tabs to apps (maybe via > an abstraction like PageData) since I doubt this will be the only apps API that > will end up needing it. > > Point being: we should make these fields match up with the tabs.Tab names. See > http://developer.chrome.com/extensions/tabs.html#type-Tab but in summary, just: > > page_title -> title > selected_text -> selectionText (to match the context menus API - and yeah, use > camel case for things in these APIs) > > Also it'd be good to add a comment like "Note: if adding properties to this then > make sure they're compatible with tabs.Tab" but I think that might get pulled in > as a documentation comment, so, never mind... Done.
	16

	17 interface Events {

	18 // Fired when the user clicks the page launcher entry in the action box.

	19 // \|pageData\| : The details of the page the user was on when the button
	not at google - send to devlin 2013/02/01 16:39:47 other IDLs I've seen don't have a space between th other IDLs I've seen don't have a space between the \| and the :. I only mention this because I want to check that the IDL parser can figure out that this is the documentation. TBH I doubt you'd notice until you enable documentation for the API, but best to avoid surprises then... Rune Fevang 2013/02/01 22:12:54 I just opened 6 random .idl files and only one of Show quoted text On 2013/02/01 16:39:47, kalman wrote: > other IDLs I've seen don't have a space between the \| and the :. I only mention > this because I want to check that the IDL parser can figure out that this is the > documentation. > > TBH I doubt you'd notice until you enable documentation for the API, but best to > avoid surprises then... I just opened 6 random .idl files and only one of them omitted the space. I don't mind changing it, but it seems like this is at least not abnormal. not at google - send to devlin 2013/02/01 22:17:11 I guess I opened the wrong random IDL file. Show quoted text On 2013/02/01 22:12:54, Rune Fevang wrote: > On 2013/02/01 16:39:47, kalman wrote: > > other IDLs I've seen don't have a space between the \| and the :. I only > mention > > this because I want to check that the IDL parser can figure out that this is > the > > documentation. > > > > TBH I doubt you'd notice until you enable documentation for the API, but best > to > > avoid surprises then... > > I just opened 6 random .idl files and only one of them omitted the space. I > don't mind changing it, but it seems like this is at least not abnormal. I guess I opened the wrong random IDL file.
	20 // was clicked.

	21 static void onClicked(PageData pageData);

	22 };

	23 };

OLD	NEW