Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: icu.gyp

Issue 1209413007: Suppress warnings for assignment inside conditionals. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Address comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
diff --git a/icu.gyp b/icu.gyp
index 8b336e96659fb88108cf9eb1200f102d78f9db0f..96ee68ea144e21d4204821d6373e03ea6360cf8f 100644
--- a/icu.gyp
+++ b/icu.gyp
@@ -243,6 +243,9 @@
# See http://bugs.icu-project.org/trac/ticket/11122
'-Wno-inline-new-delete',
'-Wno-implicit-exception-spec-mismatch',
+ # ICU has some code with the pattern:
+ # if (found = uprv_getWindowsTimeZoneInfo(...))
+ '-Wno-parentheses',
],
},
},
@@ -287,6 +290,9 @@
# enum (e.g. URES_TABLE32 which is in UResInternalType). This
# is on purpose.
'-Wno-switch',
+ # ICU has some code with the pattern:
+ # if (found = uprv_getWindowsTimeZoneInfo(...))
+ '-Wno-parentheses',
Nico 2015/06/30 18:12:10 So this is Win-only in icui18n but global in icuuc
],
},
'cflags': [
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698