Suppress warnings for assignment inside conditionals.

icu.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     'icu.gypi',
   ],
   'variables': {
     'use_system_icu%': 0,
@@ skipping 225 matching lines @@
             }],
             [ 'OS == "win" and clang==1', {
               # Note: General clang warnings should go in the
               # clang_warning_flags block above.
               'msvs_settings': {
                 'VCCLCompilerTool': {
                   'AdditionalOptions': [
                     # See http://bugs.icu-project.org/trac/ticket/11122
                     '-Wno-inline-new-delete',
                     '-Wno-implicit-exception-spec-mismatch',
+                    # ICU has some code with the pattern:
+                    #   if (found = uprv_getWindowsTimeZoneInfo(...))
+                    '-Wno-parentheses',
                   ],
                 },
               },
             }],
           ], # conditions
         },
         {
           'target_name': 'icuuc',
           'type': '<(component)',
           'sources': [
@@ skipping 24 matching lines @@
               # ICU prefers `a && b || c` over `(a && b) || c`.
               '-Wno-logical-op-parentheses',
               # ICU has some `unsigned < 0` checks.
               '-Wno-tautological-compare',
               # uresdata.c has switch(RES_GET_TYPE(x)) code. The
               # RES_GET_TYPE macro returns an UResType enum, but some switch
               # statement contains case values that aren't part of that
               # enum (e.g. URES_TABLE32 which is in UResInternalType). This
               # is on purpose.
               '-Wno-switch',
+              # ICU has some code with the pattern:
+              #   if (found = uprv_getWindowsTimeZoneInfo(...))
+              '-Wno-parentheses',

[Nico, 2015/06/30 18:12:10]

So this is Win-only in icui18n but global in icuuc? That's a bit strange, but ok
I guess. Doesn't match gn though. Maybe put it in clang_warning_flags for both
targets and remove the is_win in the gn file for consistency / simplicity?

             ],
           },
           'cflags': [
             # Since ICU wants to internally use its own deprecated APIs,
             # don't complain about it.
             '-Wno-deprecated-declarations',
             '-Wno-unused-function',
           ],
           'cflags_cc': [
             '-frtti',
@@ skipping 283 matching lines @@
           },
           'includes': [
             '../../build/shim_headers.gypi',
           ],
           'toolsets': ['target'],
         },
       ], # targets
     }],
   ], # conditions
 }