Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: sync/notifier/sync_invalidation_listener.cc

Issue 12094113: Migrate invalidator client IDs out of sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/sync_invalidation_listener.cc
diff --git a/sync/notifier/sync_invalidation_listener.cc b/sync/notifier/sync_invalidation_listener.cc
index e84bc3893b20c633e93c092c4a6e0c6071f9380a..75b009b415389e94d0aed4f50cf1f2d4e83f016b 100644
--- a/sync/notifier/sync_invalidation_listener.cc
+++ b/sync/notifier/sync_invalidation_listener.cc
@@ -95,6 +95,16 @@ void SyncInvalidationListener::Start(
registration_manager_.reset(
new RegistrationManager(invalidation_client_.get()));
+
+ // TODO(rlarocque, 124142): This call exists as part of an effort to move the
tim (not reviewing) 2013/02/05 20:04:33 nit - ooh, newfangled todo format? otherwise I'd s
rlarocque 2013/02/05 21:36:56 I thought I had seen that before... Maybe I just m
+ // invalidator's ID out of sync. It writes the provided (sync-managed) ID to
+ // storage that lives on the UI thread. Once this has been in place for a
+ // milestone or two, we can remove it and start looking for invalidator client
+ // IDs exclusively in the InvalidationStateTracker.
+ invalidation_state_tracker_.Call(
+ FROM_HERE,
+ &InvalidationStateTracker::SetInvalidatorClientId,
+ client_id);
}
void SyncInvalidationListener::UpdateCredentials(

Powered by Google App Engine
This is Rietveld 408576698