Migrate invalidator client IDs out of sync

sync/notifier/sync_invalidation_listener.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/notifier/sync_invalidation_listener.h"
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 77 matching lines @@
 
   int client_type = ipc::invalidation::ClientType::CHROME_SYNC;
   invalidation_client_.reset(
       create_invalidation_client_callback.Run(
           &sync_system_resources_, client_type, client_id,
           kApplicationName, this));
   invalidation_client_->Start();
 
   registration_manager_.reset(
       new RegistrationManager(invalidation_client_.get()));
+
+  // TODO(rlarocque, 124142): This call exists as part of an effort to move the

[tim (not reviewing), 2013/02/05 20:04:33]

nit - ooh, newfangled todo format? otherwise I'd stick to TODO(rlarocque) and
mention the bug in the comment, since most people will be trained to grep for
that...

[rlarocque, 2013/02/05 21:36:56]

I thought I had seen that before... Maybe I just made it up.

Fixed.

+  // invalidator's ID out of sync.  It writes the provided (sync-managed) ID to
+  // storage that lives on the UI thread.  Once this has been in place for a
+  // milestone or two, we can remove it and start looking for invalidator client
+  // IDs exclusively in the InvalidationStateTracker.
+  invalidation_state_tracker_.Call(
+      FROM_HERE,
+      &InvalidationStateTracker::SetInvalidatorClientId,
+      client_id);
 }
 
 void SyncInvalidationListener::UpdateCredentials(
     const std::string& email, const std::string& token) {
   DCHECK(CalledOnValidThread());
   sync_system_resources_.network()->UpdateCredentials(email, token);
 }
 
 void SyncInvalidationListener::UpdateRegisteredIds(const ObjectIdSet& ids) {
   DCHECK(CalledOnValidThread());
@@ skipping 255 matching lines @@
   EmitStateChange();
 }
 
 void SyncInvalidationListener::OnIncomingNotification(
     const notifier::Notification& notification) {
   DCHECK(CalledOnValidThread());
   // Do nothing, since this is already handled by |invalidation_client_|.
 }
 
 }  // namespace syncer