Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 12094032: Fix test harness to correctly split extra flags. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger
Modified:
7 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix test harness to correctly split extra flags. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13539

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/cctest/testcfg.py View 1 1 chunk +2 lines, -3 lines 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 10 months ago (2013-01-29 13:17:50 UTC) #1
Jakob Kummerow
test/cctest/testcfg.py needs updating too. Line 51ff must be: output = commands.Execute(context.command_prefix + [shell, "--list"] + ...
7 years, 10 months ago (2013-01-29 13:20:38 UTC) #2
Michael Starzinger
Comments addressed.
7 years, 10 months ago (2013-01-29 13:23:49 UTC) #3
Jakob Kummerow
7 years, 10 months ago (2013-01-29 13:24:19 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698