Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: tools/testrunner/local/execution.py

Issue 12094032: Fix test harness to correctly split extra flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/run-tests.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 d8testflag = [] 164 d8testflag = []
165 shell = test.suite.shell() 165 shell = test.suite.shell()
166 if shell == "d8": 166 if shell == "d8":
167 d8testflag = ["--test"] 167 d8testflag = ["--test"]
168 if utils.IsWindows(): 168 if utils.IsWindows():
169 shell += ".exe" 169 shell += ".exe"
170 cmd = (self.context.command_prefix + 170 cmd = (self.context.command_prefix +
171 [os.path.abspath(os.path.join(self.context.shell_dir, shell))] + 171 [os.path.abspath(os.path.join(self.context.shell_dir, shell))] +
172 d8testflag + 172 d8testflag +
173 test.suite.GetFlagsForTestCase(test, self.context) + 173 test.suite.GetFlagsForTestCase(test, self.context) +
174 [self.context.extra_flags]) 174 self.context.extra_flags)
175 return cmd 175 return cmd
176 176
177 177
178 class BreakNowException(Exception): 178 class BreakNowException(Exception):
179 def __init__(self, value): 179 def __init__(self, value):
180 self.value = value 180 self.value = value
181 def __str__(self): 181 def __str__(self):
182 return repr(self.value) 182 return repr(self.value)
OLDNEW
« no previous file with comments | « tools/run-tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698