Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: components/password_manager/core/common/credential_manager_types_unittest.cc

Issue 1209363003: Rename avatar to icon in the credential manager in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added TODO. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/common/credential_manager_types.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/common/credential_manager_types_unittest.cc
diff --git a/components/password_manager/core/common/credential_manager_types_unittest.cc b/components/password_manager/core/common/credential_manager_types_unittest.cc
index 66788e4b88a466aa3ff914afd07c123800a0aaae..cdbe48f6bd4705fd145cf2d6a77422b0321b3a46 100644
--- a/components/password_manager/core/common/credential_manager_types_unittest.cc
+++ b/components/password_manager/core/common/credential_manager_types_unittest.cc
@@ -16,12 +16,12 @@ class CredentialManagerTypesTest : public testing::Test {
public:
CredentialManagerTypesTest()
: origin_(GURL("https://example.test/")),
- avatar_(GURL("https://fast-cdn.test/avatar.png")),
+ icon_(GURL("https://fast-cdn.test/icon.png")),
federation_(GURL("https://federation.test/")) {}
protected:
GURL origin_;
- GURL avatar_;
+ GURL icon_;
GURL federation_;
};
@@ -40,14 +40,14 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormFederation) {
info.id = base::ASCIIToUTF16("id");
info.name = base::ASCIIToUTF16("name");
- info.avatar = avatar_;
+ info.icon = icon_;
info.federation = federation_;
info.type = CredentialType::CREDENTIAL_TYPE_FEDERATED;
form = CreatePasswordFormFromCredentialInfo(info, origin_);
ASSERT_NE(nullptr, form.get());
- EXPECT_EQ(info.avatar, form->avatar_url);
+ EXPECT_EQ(info.icon, form->avatar_url);
EXPECT_EQ(info.name, form->display_name);
EXPECT_EQ(origin_, form->origin);
EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, form->scheme);
@@ -65,14 +65,14 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormLocal) {
info.id = base::ASCIIToUTF16("id");
info.name = base::ASCIIToUTF16("name");
- info.avatar = avatar_;
+ info.icon = icon_;
info.password = base::ASCIIToUTF16("password");
info.type = CredentialType::CREDENTIAL_TYPE_PASSWORD;
form = CreatePasswordFormFromCredentialInfo(info, origin_);
ASSERT_NE(nullptr, form.get());
- EXPECT_EQ(info.avatar, form->avatar_url);
+ EXPECT_EQ(info.icon, form->avatar_url);
EXPECT_EQ(info.name, form->display_name);
EXPECT_EQ(origin_, form->origin);
EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, form->scheme);
« no previous file with comments | « components/password_manager/core/common/credential_manager_types.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698