components/password_manager/core/common/credential_manager_types.cc - Issue 1209363003: Rename avatar to icon in the credential manager in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/credential_manager_types.cc

Issue 1209363003: Rename avatar to icon in the credential manager in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/common/credential_manager_types.h ('k') | components/password_manager/core/common/credential_manager_types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/credential_manager_types.cc

diff --git a/components/password_manager/core/common/credential_manager_types.cc b/components/password_manager/core/common/credential_manager_types.cc

index 5e4f5b5f95386dcf2d9a4b2894a2a35b2f68f733..fb982f907a0534b60812095760657602f634bf4f 100644

--- a/components/password_manager/core/common/credential_manager_types.cc

+++ b/components/password_manager/core/common/credential_manager_types.cc

@@ -17,7 +17,7 @@ CredentialInfo::CredentialInfo(const autofill::PasswordForm& form,

: type(form_type),

id(form.username_value),

name(form.display_name),

- avatar(form.avatar_url),

+ icon(form.avatar_url),

password(form.password_value),

federation(form.federation_url) {

switch (form_type) {

@@ -45,7 +45,7 @@ scoped_ptr<autofill::PasswordForm> CreatePasswordFormFromCredentialInfo(

return form.Pass();

form.reset(new autofill::PasswordForm);

- form->avatar_url = info.avatar;

+ form->avatar_url = info.icon;

form->display_name = info.name;

form->federation_url = info.federation;

form->origin = origin;