Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 12093107: Extract testing utilities from gdata_wapi_operations_unittest to test_util. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
satorux1, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Extract testing utilities from gdata_wapi_operations_unittest to test_util. This is preparation to implement Download operation, whose test uses the extracted utilities in base_operations_server_unittest.cc BUG=148627 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -34 lines) Patch
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 5 chunks +7 lines, -33 lines 0 comments Download
M chrome/browser/google_apis/test_util.h View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-02-04 07:17:11 UTC) #1
satorux1
LGTM
7 years, 10 months ago (2013-02-04 07:37:10 UTC) #2
kinaba
lgtm
7 years, 10 months ago (2013-02-04 07:40:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12093107/1
7 years, 10 months ago (2013-02-04 14:54:11 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-04 15:16:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12093107/1
7 years, 10 months ago (2013-02-04 15:44:21 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-04 20:19:37 UTC) #7
Message was sent while issue was closed.
Change committed as 180494

Powered by Google App Engine
This is Rietveld 408576698