Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/browser/extensions/external_provider_interface.h

Index: chrome/browser/extensions/external_provider_interface.h
diff --git a/chrome/browser/extensions/external_provider_interface.h b/chrome/browser/extensions/external_provider_interface.h
index 8a71a9dd66f283688e6c40b4f0d8c32cb694e14e..79e450d23f106a9ebac0167e0d49f3c006a7144e 100644
--- a/chrome/browser/extensions/external_provider_interface.h
+++ b/chrome/browser/extensions/external_provider_interface.h
@@ -8,7 +8,8 @@
 #include <vector>
 
 #include "base/memory/linked_ptr.h"
-#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest.h"
+#include "googleurl/src/gurl.h"

[Jeffrey Yasskin, 2013/01/29 22:54:07]

Strictly, GURL could be a forward declaration here.  Using the #include is
somewhat better if users take advantage of any implicit conversions.

[Yoyo Zhou, 2013/01/30 01:16:01]

Done.

 
 class FilePath;
 class Version;
@@ -33,7 +34,7 @@ class ExternalProviderInterface {
         const std::string& id,
         const Version* version,
         const FilePath& path,
-        Extension::Location location,
+        Manifest::Location location,
         int creation_flags,
         bool mark_acknowledged) = 0;
 
@@ -43,7 +44,7 @@ class ExternalProviderInterface {
     virtual bool OnExternalExtensionUpdateUrlFound(
         const std::string& id,
         const GURL& update_url,
-        Extension::Location location) = 0;
+        Manifest::Location location) = 0;
 
     // Called after all the external extensions have been reported
     // through the above two methods. |provider| is a pointer to the
@@ -75,7 +76,7 @@ class ExternalProviderInterface {
   // provider type, it will not be changed.
   // This function is no longer used outside unit tests.
   virtual bool GetExtensionDetails(const std::string& id,
-                                   Extension::Location* location,
+                                   Manifest::Location* location,
                                    scoped_ptr<Version>* version) const = 0;
 
   // Determines if this provider had loaded the list of external extensions