Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/browser/extensions/external_provider_impl.h

Index: chrome/browser/extensions/external_provider_impl.h
diff --git a/chrome/browser/extensions/external_provider_impl.h b/chrome/browser/extensions/external_provider_impl.h
index e75cbd1824d569b259a1adb45c1eff6df6268d23..05dd4eb55b628dc2cbb6f48d6320ec85163f12c2 100644
--- a/chrome/browser/extensions/external_provider_impl.h
+++ b/chrome/browser/extensions/external_provider_impl.h
@@ -20,8 +20,8 @@ class DictionaryValue;
 }
 
 namespace extensions {
-class Extension;
 class ExternalLoader;
+class Manifest;

[Jeffrey Yasskin, 2013/01/29 22:54:07]

If you're using Manifest::anything, a forward declaration isn't enough.
Something in the #includes must already be including manifest.h (and
extension.h), so just include it directly.

[Yoyo Zhou, 2013/01/30 01:16:01]

Done.

 
 // A specialization of the ExternalProvider that uses an instance of
 // ExternalLoader to provide external extensions. This class can be seen as a
@@ -35,11 +35,11 @@ class ExternalProviderImpl : public ExternalProviderInterface {
   // |crx_location|: extensions originating from crx files
   // |download_location|: extensions originating from update URLs
   // If either of the origins is not supported by this provider, then it should
-  // be initialized as Extensions::INVALID.
+  // be initialized as Manifest::INVALID_LOCATION.
   ExternalProviderImpl(VisitorInterface* service,
                        ExternalLoader* loader,
-                       Extension::Location crx_location,
-                       Extension::Location download_location,
+                       Manifest::Location crx_location,
+                       Manifest::Location download_location,
                        int creation_flags);
 
   virtual ~ExternalProviderImpl();
@@ -59,7 +59,7 @@ class ExternalProviderImpl : public ExternalProviderInterface {
   virtual void VisitRegisteredExtension() OVERRIDE;
   virtual bool HasExtension(const std::string& id) const OVERRIDE;
   virtual bool GetExtensionDetails(const std::string& id,
-                                   Extension::Location* location,
+                                   Manifest::Location* location,
                                    scoped_ptr<Version>* version) const OVERRIDE;
 
   virtual bool IsReady() const OVERRIDE;
@@ -78,11 +78,11 @@ class ExternalProviderImpl : public ExternalProviderInterface {
  private:
   // Location for external extensions that are provided by this provider from
   // local crx files.
-  const Extension::Location crx_location_;
+  const Manifest::Location crx_location_;
 
   // Location for external extensions that are provided by this provider from
   // update URLs.
-  const Extension::Location download_location_;
+  const Manifest::Location download_location_;
 
   // Weak pointer to the object that consumes the external extensions.
   // This is zeroed out by: ServiceShutdown()