chrome/browser/extensions/extension_startup_browsertest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | chrome/browser/extensions/extension_system.cc » ('j') | chrome/browser/extensions/external_provider_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_startup_browsertest.cc

diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc

index f1984c59eef5bb5962e704e5815a28479020a807..ad92f48b5d1793dd1f690c706344565743deee7b 100644

--- a/chrome/browser/extensions/extension_startup_browsertest.cc

+++ b/chrome/browser/extensions/extension_startup_browsertest.cc

@@ -98,7 +98,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {

int found_extensions = 0;

for (ExtensionSet::const_iterator it = service->extensions()->begin();

it != service->extensions()->end(); ++it)

- if ((*it)->location() != extensions::Extension::COMPONENT)

+ if ((*it)->location() != extensions::Manifest::COMPONENT)

found_extensions++;

ASSERT_EQ(static_cast<uint32>(num_expected_extensions),

@@ -191,7 +191,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, MAYBE_NoFileAccess) {

browser()->profile())->extension_service();

for (ExtensionSet::const_iterator it = service->extensions()->begin();

it != service->extensions()->end(); ++it) {

- if ((*it)->location() == extensions::Extension::COMPONENT)

+ if ((*it)->location() == extensions::Manifest::COMPONENT)

continue;

if (service->AllowFileAccess(*it))

extension_list.push_back(*it);