Changed the constraints for hiding the top controls

chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index 1a5933485bfadc2b4125f5b4b18a6208adf49674..5e8308614feb134afce83aa014681ad3cd68f390 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -189,7 +189,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
 
     private boolean mIsClosing;
     private boolean mIsShowingErrorPage;
-    private boolean mIsImeShowing;
 
     private Bitmap mFavicon;
 
@@ -516,7 +515,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
         @Override
         public void onImeStateChangeRequested(boolean requestShow) {
             if (getFullscreenManager() == null) return;
-            mIsImeShowing = requestShow;
             updateFullscreenEnabledState();
         }
     }
@@ -1312,7 +1310,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
             mFullscreenHungRendererToken = FullscreenManager.INVALID_TOKEN;
             mPreviousFullscreenOverdrawBottomHeight = Float.NaN;
         }
-        mIsImeShowing = false;
 
         hideInternal();
 
@@ -2476,7 +2473,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
 
         enableHidingTopControls &=
                 !AccessibilityUtil.isAccessibilityEnabled(getApplicationContext());
-        enableHidingTopControls &= !mIsImeShowing;
+        enableHidingTopControls &= !mContentViewCore.isFocusedNodeEditable();

[jdduke (slow), 2015/06/26 15:03:08]

With this change I think we still need a way to notify Tab when the editability
of the focused area changes (so that it can update the top controls
constraints).

[Ted C, 2015/06/26 16:49:53]

Agreed.  And while this feature is woefully under tested, it would be good to
write some basic tests ensuring this works correctly.

         enableHidingTopControls &= !mIsShowingErrorPage;
         enableHidingTopControls &= !webContents.isShowingInterstitialPage();
         enableHidingTopControls &= (mFullscreenManager != null);