Changed the constraints for hiding the top controls

chrome/android/java/src/org/chromium/chrome/browser/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Activity;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Color;
@@ skipping 171 matching lines @@
      */
     private int mParentId = INVALID_TAB_ID;
 
     /**
      * Whether the tab should be grouped with its parent tab.
      */
     private boolean mGroupedWithParent = true;
 
     private boolean mIsClosing;
     private boolean mIsShowingErrorPage;
-    private boolean mIsImeShowing;
 
     private Bitmap mFavicon;
 
     private String mFaviconUrl;
 
     /**
      * The number of pixel of 16DP.
      */
     private int mNumPixel16DP;
 
@@ skipping 306 matching lines @@
         public void onImeEvent() {
             // Some text was set in the page. Don't reuse it if a tab is
             // open from the same external application, we might lose some
             // user data.
             mAppAssociatedWith = null;
         }
 
         @Override
         public void onImeStateChangeRequested(boolean requestShow) {
             if (getFullscreenManager() == null) return;
-            mIsImeShowing = requestShow;
             updateFullscreenEnabledState();
         }
     }
 
     private class TabContextMenuPopulator extends ContextMenuPopulatorWrapper {
         public TabContextMenuPopulator(ContextMenuPopulator populator) {
             super(populator);
         }
 
         @Override
@@ skipping 775 matching lines @@
 
         if (mContentViewCore != null) mContentViewCore.onHide();
 
         // Clean up any fullscreen state that might impact other tabs.
         if (mFullscreenManager != null) {
             mFullscreenManager.setPersistentFullscreenMode(false);
             mFullscreenManager.hideControlsPersistent(mFullscreenHungRendererToken);
             mFullscreenHungRendererToken = FullscreenManager.INVALID_TOKEN;
             mPreviousFullscreenOverdrawBottomHeight = Float.NaN;
         }
-        mIsImeShowing = false;
 
         hideInternal();
 
         for (TabObserver observer : mObservers) observer.onHidden(this);
     }
 
     /**
      * Called when the Tab is being hidden to perform any subclass-specific tasks.
      */
     protected void hideInternal() {
@@ skipping 1143 matching lines @@
         String url = getUrl();
         boolean enableHidingTopControls = url != null && !url.startsWith(UrlConstants.CHROME_SCHEME)
                 && !url.startsWith(UrlConstants.CHROME_NATIVE_SCHEME);
 
         int securityState = getSecurityLevel();
         enableHidingTopControls &= (securityState != ConnectionSecurityLevel.SECURITY_ERROR
                 && securityState != ConnectionSecurityLevel.SECURITY_WARNING);
 
         enableHidingTopControls &=
                 !AccessibilityUtil.isAccessibilityEnabled(getApplicationContext());
-        enableHidingTopControls &= !mIsImeShowing;
+        enableHidingTopControls &= !mContentViewCore.isFocusedNodeEditable();

[jdduke (slow), 2015/06/26 15:03:08]

With this change I think we still need a way to notify Tab when the editability
of the focused area changes (so that it can update the top controls
constraints).

[Ted C, 2015/06/26 16:49:53]

Agreed.  And while this feature is woefully under tested, it would be good to
write some basic tests ensuring this works correctly.

         enableHidingTopControls &= !mIsShowingErrorPage;
         enableHidingTopControls &= !webContents.isShowingInterstitialPage();
         enableHidingTopControls &= (mFullscreenManager != null);
 
         return enableHidingTopControls;
     }
 
     /**
      * Performs any subclass-specific tasks when the Tab crashes.
      */
@@ skipping 284 matching lines @@
     private native void nativeAttachToTabContentManager(long nativeTabAndroid,
             TabContentManager tabContentManager);
     private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid,
             ContentViewCore content, boolean visible);
     private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid,
             ContentViewCore content);
     private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
 
     private static native void nativeRecordStartupToCommitUma();
 }