Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 12092114: Documenting misleading DataTransfer API. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 8 months ago
Reviewers:
Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Documenting misleading DataTransfer API. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21216

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M tools/dom/docs/docs.json View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
blois
7 years, 10 months ago (2013-02-01 18:04:40 UTC) #1
Andrei Mouravski
https://codereview.chromium.org/12092114/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12092114/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode5832 sdk/lib/html/dart2js/html_dart2js.dart:5832: + * Gets the data for the specified MIME ...
7 years, 10 months ago (2013-02-01 18:23:21 UTC) #2
blois
On 2013/02/01 18:23:21, Andrei Mouravski wrote: > https://codereview.chromium.org/12092114/diff/1/sdk/lib/html/dart2js/html_dart2js.dart > File sdk/lib/html/dart2js/html_dart2js.dart (right): > > https://codereview.chromium.org/12092114/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode5832 ...
7 years, 10 months ago (2013-02-01 18:31:24 UTC) #3
Andrei Mouravski
https://code.google.com/p/dart/issues/detail?id=8260 filed. https://codereview.chromium.org/12092114/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12092114/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart#newcode5834 sdk/lib/html/dart2js/html_dart2js.dart:5834: + * The data is only available ...
7 years, 10 months ago (2013-02-01 18:40:45 UTC) #4
Andrei Mouravski
Will this be going in any time?
7 years, 9 months ago (2013-03-07 00:59:51 UTC) #5
blois
https://codereview.chromium.org/12092114/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12092114/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart#newcode5835 sdk/lib/html/dart2js/html_dart2js.dart:5835: + * onDrop event) and will return `null` before ...
7 years, 8 months ago (2013-04-10 00:26:47 UTC) #6
Andrei Mouravski
lgtm
7 years, 8 months ago (2013-04-10 02:33:50 UTC) #7
blois
7 years, 8 months ago (2013-04-10 16:22:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r21216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698