Implement Webviewclient.onReceivedSslError

android_webview/browser/aw_content_browser_client.cc

Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 5a53dd1cb0f381f96c5b860ad44640bf7912af37..6258305e069456303e635e52de9b99bb7fa48443 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -5,6 +5,7 @@
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
+#include "android_webview/browser/aw_certificate_error_handler_base.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
@@ -19,6 +20,7 @@
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/url_constants.h"
 #include "grit/ui_resources.h"
+#include "net/base/ssl_info.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace {
@@ -206,9 +208,12 @@ void AwContentBrowserClient::AllowCertificateError(
     bool strict_enforcement,
     const base::Callback<void(bool)>& callback,
     bool* cancel_request) {
-  // TODO(boliu): Implement this to power WebViewClient.onReceivedSslError.
-  NOTIMPLEMENTED();
-  *cancel_request = true;
+
+  AwCertificateErrorHandlerBase* error_handler =
+      AwCertificateErrorHandlerBase::FromID(render_process_id, render_view_id);
+  DCHECK(error_handler);

[mkosiba (inactive), 2013/02/04 12:51:31]

this is pointless, we'll crash in the next line anyway. It does seem like a more
robust solution is easily available:

 if (error_handler) {
    ...
 } else {
    DCHECK(false);
    *cancel_request = true;
 }

[sgurun-gerrit only, 2013/02/21 23:32:32]

himm, if there is a possibility of rvh not existing, I guess DCHECK would be
wrong anyway.

On 2013/02/04 12:51:31, Martin Kosiba wrote:
Done.

+  error_handler->AllowCertificateError(cert_error, ssl_info.cert, request_url,
+      callback, cancel_request);
 }
 
 WebKit::WebNotificationPresenter::Permission