Implement Webviewclient.onReceivedSslError

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
+#include "android_webview/browser/aw_certificate_error_handler_base.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h"
 #include "android_webview/common/url_constants.h"
 #include "base/android/locale_utils.h"
 #include "base/base_paths_android.h"
 #include "base/path_service.h"
 #include "content/public/browser/access_token_store.h"
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/url_constants.h"
 #include "grit/ui_resources.h"
+#include "net/base/ssl_info.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace {
 
 class DummyAccessTokenStore : public content::AccessTokenStore {
  public:
   DummyAccessTokenStore() { }
 
   virtual void LoadAccessTokens(
       const LoadAccessTokensCallbackType& request) OVERRIDE { }
@@ skipping 167 matching lines @@
 void AwContentBrowserClient::AllowCertificateError(
     int render_process_id,
     int render_view_id,
     int cert_error,
     const net::SSLInfo& ssl_info,
     const GURL& request_url,
     bool overridable,
     bool strict_enforcement,
     const base::Callback<void(bool)>& callback,
     bool* cancel_request) {
-  // TODO(boliu): Implement this to power WebViewClient.onReceivedSslError.
-  NOTIMPLEMENTED();
-  *cancel_request = true;
+
+  AwCertificateErrorHandlerBase* error_handler =
+      AwCertificateErrorHandlerBase::FromID(render_process_id, render_view_id);
+  DCHECK(error_handler);

[mkosiba (inactive), 2013/02/04 12:51:31]

this is pointless, we'll crash in the next line anyway. It does seem like a more
robust solution is easily available:

 if (error_handler) {
    ...
 } else {
    DCHECK(false);
    *cancel_request = true;
 }

[sgurun-gerrit only, 2013/02/21 23:32:32]

himm, if there is a possibility of rvh not existing, I guess DCHECK would be
wrong anyway.

On 2013/02/04 12:51:31, Martin Kosiba wrote:
Done.

+  error_handler->AllowCertificateError(cert_error, ssl_info.cert, request_url,
+      callback, cancel_request);
 }
 
 WebKit::WebNotificationPresenter::Permission
     AwContentBrowserClient::CheckDesktopNotificationPermission(
         const GURL& source_url,
         content::ResourceContext* context,
         int render_process_id) {
   // Android WebView does not support notifications, so return Denied here.
   return WebKit::WebNotificationPresenter::PermissionDenied;
 }
@@ skipping 105 matching lines @@
 
 bool AwContentBrowserClient::AllowPepperSocketAPI(
     content::BrowserContext* browser_context,
     const GURL& url,
     const content::SocketPermissionRequest& params) {
   NOTREACHED() << "Android WebView does not support plugins";
   return false;
 }
 
 }  // namespace android_webview