build/common.gypi - Issue 12091004: POSIX: re-enable strict aliasing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 12091004: POSIX: re-enable strict aliasing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 50144f4e63ce5c421f6814a2eb6f8b0bbef59952..28fd7dfeb47d1d69a05eb4783d04c8ae85ae8554 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2324,6 +2324,10 @@

'-Wno-deprecated',

'cflags': [

+ # Do not assume the code is strict-aliasing-safe. This can induce

+ # strange crashes, and we ignore warnings in third-party code.

+ # The reference bug for this is http://crbug.com/32204 .

+ '-fno-strict-aliasing',

# Don't warn about printf format problems.

# This is off by default in gcc but on in Ubuntu's gcc(!).

'-Wno-format',

@@ -2747,7 +2751,6 @@

'<(werror)', # See note above about the werror variable.

'-pthread',

'-fno-exceptions',

- '-fno-strict-aliasing', # See http://crbug.com/32204

'-Wall',

# TODO(evan): turn this back on once all the builds work.

# '-Wextra',

« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | no next file with comments »