Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: build/common.gypi

Issue 12091004: POSIX: re-enable strict aliasing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2306 matching lines...) Expand 10 before | Expand all | Expand 10 after
2317 # so remove any existing warning-enabling flags like -Wall. 2317 # so remove any existing warning-enabling flags like -Wall.
2318 'cflags!': [ 2318 'cflags!': [
2319 '-Wall', 2319 '-Wall',
2320 '-Wextra', 2320 '-Wextra',
2321 ], 2321 ],
2322 'cflags_cc': [ 2322 'cflags_cc': [
2323 # Don't warn about hash_map in third-party code. 2323 # Don't warn about hash_map in third-party code.
2324 '-Wno-deprecated', 2324 '-Wno-deprecated',
2325 ], 2325 ],
2326 'cflags': [ 2326 'cflags': [
2327 # Do not assume the code is strict-aliasing-safe. This can induce
2328 # strange crashes, and we ignore warnings in third-party code.
2329 # The reference bug for this is http://crbug.com/32204 .
2330 '-fno-strict-aliasing',
2327 # Don't warn about printf format problems. 2331 # Don't warn about printf format problems.
2328 # This is off by default in gcc but on in Ubuntu's gcc(!). 2332 # This is off by default in gcc but on in Ubuntu's gcc(!).
2329 '-Wno-format', 2333 '-Wno-format',
2330 ], 2334 ],
2331 'cflags_cc!': [ 2335 'cflags_cc!': [
2332 # TODO(fischman): remove this. 2336 # TODO(fischman): remove this.
2333 # http://code.google.com/p/chromium/issues/detail?id=90453 2337 # http://code.google.com/p/chromium/issues/detail?id=90453
2334 '-Wsign-compare', 2338 '-Wsign-compare',
2335 ] 2339 ]
2336 }], 2340 }],
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
2740 'werror%': '-Werror', 2744 'werror%': '-Werror',
2741 'libraries_for_target%': '', 2745 'libraries_for_target%': '',
2742 }, 2746 },
2743 'defines': [ 2747 'defines': [
2744 '_FILE_OFFSET_BITS=64', 2748 '_FILE_OFFSET_BITS=64',
2745 ], 2749 ],
2746 'cflags': [ 2750 'cflags': [
2747 '<(werror)', # See note above about the werror variable. 2751 '<(werror)', # See note above about the werror variable.
2748 '-pthread', 2752 '-pthread',
2749 '-fno-exceptions', 2753 '-fno-exceptions',
2750 '-fno-strict-aliasing', # See http://crbug.com/32204
2751 '-Wall', 2754 '-Wall',
2752 # TODO(evan): turn this back on once all the builds work. 2755 # TODO(evan): turn this back on once all the builds work.
2753 # '-Wextra', 2756 # '-Wextra',
2754 # Don't warn about unused function params. We use those everywhere. 2757 # Don't warn about unused function params. We use those everywhere.
2755 '-Wno-unused-parameter', 2758 '-Wno-unused-parameter',
2756 # Don't warn about the "struct foo f = {0};" initialization pattern. 2759 # Don't warn about the "struct foo f = {0};" initialization pattern.
2757 '-Wno-missing-field-initializers', 2760 '-Wno-missing-field-initializers',
2758 # Don't export any symbols (for example, to plugins we dlopen()). 2761 # Don't export any symbols (for example, to plugins we dlopen()).
2759 # Note: this is *required* to make some plugins work. 2762 # Note: this is *required* to make some plugins work.
2760 '-fvisibility=hidden', 2763 '-fvisibility=hidden',
(...skipping 1943 matching lines...) Expand 10 before | Expand all | Expand 10 after
4704 # settings in target dicts. SYMROOT is a special case, because many other 4707 # settings in target dicts. SYMROOT is a special case, because many other
4705 # Xcode variables depend on it, including variables such as 4708 # Xcode variables depend on it, including variables such as
4706 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4709 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4707 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4710 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4708 # files to appear (when present) in the UI as actual files and not red 4711 # files to appear (when present) in the UI as actual files and not red
4709 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4712 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4710 # and therefore SYMROOT, needs to be set at the project level. 4713 # and therefore SYMROOT, needs to be set at the project level.
4711 'SYMROOT': '<(DEPTH)/xcodebuild', 4714 'SYMROOT': '<(DEPTH)/xcodebuild',
4712 }, 4715 },
4713 } 4716 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698