Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1209043002: Bundle main thread overscroll data with event ack messages (Closed)

Created:
5 years, 6 months ago by jdduke (slow)
Modified:
5 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bundle main thread overscroll data with event ack messages Currently, every main thread overscroll event will trigger an overscroll IPC notification. However, most such events occur in the context of handling input events. For such cases, bundle the overscroll data with the event ack. BUG=442859, 502146 Committed: https://crrev.com/c05612bf6588fd75450b28d1e01e12493efbd409 Cr-Commit-Position: refs/heads/master@{#336293}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -11 lines) Patch
M content/renderer/render_widget.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 6 chunks +22 lines, -4 lines 0 comments Download
M content/renderer/render_widget_unittest.cc View 6 chunks +76 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jdduke (slow)
sievers@: PTAL, thanks. As an aside, it looks like RenderWidget::OnHandleInputEvent has grown into a bit ...
5 years, 6 months ago (2015-06-25 18:55:56 UTC) #2
no sievers
lgtm
5 years, 6 months ago (2015-06-25 22:12:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209043002/80001
5 years, 6 months ago (2015-06-25 22:23:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 6 months ago (2015-06-25 23:13:26 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 23:14:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c05612bf6588fd75450b28d1e01e12493efbd409
Cr-Commit-Position: refs/heads/master@{#336293}

Powered by Google App Engine
This is Rietveld 408576698