Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 12090072: Work around a bug in Clang that optimizes away a NULL check (Closed)

Created:
7 years, 10 months ago by Jakob Kummerow
Modified:
7 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, danno
Visibility:
Public.

Description

Work around a bug in Clang that optimizes away a NULL check Committed: http://code.google.com/p/v8/source/detail?r=13562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/spaces.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Michael: PTAL. Danno: Just FYI.
7 years, 10 months ago (2013-01-30 17:32:40 UTC) #1
Michael Starzinger
LGTM. Beautiful, just beautiful. :P
7 years, 10 months ago (2013-01-30 17:34:08 UTC) #2
hans
Is there a Clang bug filed for this?
7 years, 10 months ago (2013-01-30 17:58:33 UTC) #3
Jakob Kummerow
7 years, 10 months ago (2013-01-31 13:19:22 UTC) #4
Message was sent while issue was closed.
On 2013/01/30 17:58:33, hans wrote:
> Is there a Clang bug filed for this?

I haven't filed one. Main reason is that I don't have a reduced repro, which
would be kind of helpful.

Powered by Google App Engine
This is Rietveld 408576698