src/spaces.cc - Issue 12090072: Work around a bug in Clang that optimizes away a NULL check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/spaces.cc

Issue 12090072: Work around a bug in Clang that optimizes away a NULL check (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/spaces.cc

diff --git a/src/spaces.cc b/src/spaces.cc

index 711cde1c662c0c6c59d7148c2e6dec21f8f878f4..f3c5a08c5e1cc29d2a9590d194f5120789a5a44b 100644

--- a/src/spaces.cc

+++ b/src/spaces.cc

@@ -711,7 +711,7 @@ LargePage* MemoryAllocator::AllocateLargePage(intptr_t object_size,

void MemoryAllocator::Free(MemoryChunk* chunk) {

LOG(isolate_, DeleteEvent("MemoryChunk", chunk));

- if (chunk->owner() != NULL) {

+ if (chunk->has_owner()) {

ObjectSpace space =

static_cast<ObjectSpace>(1 << chunk->owner()->identity());

PerformAllocationCallback(space, kAllocationActionFree, chunk->size());

« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »