Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1209003004: Revert of Revert of added stroking support to GrAALinearizingConvexPathRenderer (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
CC:
reviews_skia.org, f(malita)
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of added stroking support to GrAALinearizingConvexPathRenderer (patchset #1 id:1 of https://codereview.chromium.org/1212833002/) Reason for revert: Manual roll is in: https://codereview.chromium.org/1212373002 Let's re-land this. Original issue's description: > Revert of added stroking support to GrAALinearizingConvexPathRenderer (patchset #6 id:100001 of https://codereview.chromium.org/1180903006/) > > Reason for revert: > speculative revert to try to fix DEPS roll (layouttests) > > Original issue's description: > > added stroking support to GrAALinearizingConvexPathRenderer > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/2436f191e6602953b32a51cf50f2d7a4e2af90fd > > TBR=bsalomon@google.com,robertphillips@google.com,ethannicholas@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9730f4a663534009d216c2f6d834bd534dd44a3d TBR=bsalomon@google.com,robertphillips@google.com,ethannicholas@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/bd5d7e75c1ef08816bfd8eed52150cd716e15d5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -357 lines) Patch
M src/core/SkPathPriv.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrAAConvexTessellator.h View 9 chunks +36 lines, -29 lines 0 comments Download
M src/gpu/GrAAConvexTessellator.cpp View 34 chunks +340 lines, -310 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 9 chunks +33 lines, -12 lines 0 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Created Revert of Revert of added stroking support to GrAALinearizingConvexPathRenderer
5 years, 6 months ago (2015-06-26 14:18:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209003004/1
5 years, 6 months ago (2015-06-26 14:18:22 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 14:18:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd5d7e75c1ef08816bfd8eed52150cd716e15d5b

Powered by Google App Engine
This is Rietveld 408576698