Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: cc/input_handler.h

Issue 12090014: Add a bit to not bubble scrolls to parent scrolling layers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layer_tree_host_impl.h » ('j') | cc/layer_tree_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input_handler.h
diff --git a/cc/input_handler.h b/cc/input_handler.h
index 2016f282c75c887f9e49bc68cc50fc7358e5ceab..662cae4b25c8742b5a659388911586d4e52cfe04 100644
--- a/cc/input_handler.h
+++ b/cc/input_handler.h
@@ -46,7 +46,7 @@ public:
// direction at all, then false is returned. If any layer is moved, then
// true is returned.
// Should only be called if scrollBegin() returned ScrollStarted.
- virtual bool scrollBy(const gfx::Point&, const gfx::Vector2d&) = 0;
+ virtual bool scrollBy(const gfx::Point&, const gfx::Vector2d&, bool shouldBubble) = 0;
jamesr 2013/01/29 05:52:24 why do you need another bool? you have the scroll
Sami 2013/01/29 11:42:34 We still want to bubble slow gesture scrolls as op
Yusuf 2013/01/29 18:59:21 OK. Sorry I didn't notice that we can use scrollTy
// Stop scrolling the selected layer. Should only be called if scrollBegin()
// returned ScrollStarted.
« no previous file with comments | « no previous file | cc/layer_tree_host_impl.h » ('j') | cc/layer_tree_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698