Issue 1208993020: Change all child.paint calls to canvas.paintChild and update the test results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208993020: Change all child.paint calls to canvas.paintChild and update the test results. (Closed)

Created:
5 years, 5 months ago by iansf

Modified:
5 years, 5 months ago

Reviewers:
abarth, Hixie, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1330 lines, -848 lines)			Patch
M	sky/sdk/lib/rendering/box.dart	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	sky/tests/examples/sector-expected.txt	View	7 chunks	+641 lines, -447 lines	0 comments	Download
M	sky/tests/examples/stocks-expected.txt	View	2 chunks	+170 lines, -98 lines	0 comments	Download
M	sky/tests/examples/styled_text-expected.txt	View	1 chunk	+121 lines, -87 lines	0 comments	Download
M	sky/tests/examples/tabs-expected.txt	View	1 chunk	+157 lines, -91 lines	0 comments	Download
M	sky/tests/raw/box_layout-expected.txt	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	sky/tests/raw/padding_deflate-expected.txt	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/tests/raw/render_flex-expected.txt	View	1 chunk	+28 lines, -22 lines	0 comments	Download
M	sky/tests/widgets/buttons-expected.txt	View	3 chunks	+39 lines, -15 lines	0 comments	Download
M	sky/tests/widgets/dialog-expected.txt	View	1 chunk	+25 lines, -17 lines	0 comments	Download
M	sky/tests/widgets/syncs1-expected.txt	View	3 chunks	+132 lines, -60 lines	0 comments	Download

Total messages: 4 (1 generated)

iansf

Trying to break up large perf changeset into smaller, more easily understood changes so that ...

5 years, 5 months ago (2015-07-08 19:41:12 UTC) #1

iansf

5 years, 5 months ago (2015-07-08 19:48:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f8b26df8edd7c65687f074ac00d408c7dac0fea1 (presubmit successful).