Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: sky/sdk/lib/rendering/box.dart

Issue 1208993020: Change all child.paint calls to canvas.paintChild and update the test results. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/tests/examples/sector-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/rendering/box.dart
diff --git a/sky/sdk/lib/rendering/box.dart b/sky/sdk/lib/rendering/box.dart
index 88e219698cc77d1c8eaf9deb95b581265d3f12ca..bf25d33163fb896f324bdcc0a29d2bf5390f4da1 100644
--- a/sky/sdk/lib/rendering/box.dart
+++ b/sky/sdk/lib/rendering/box.dart
@@ -489,7 +489,7 @@ class RenderProxyBox extends RenderBox with RenderObjectWithChildMixin<RenderBox
void paint(PaintingCanvas canvas, Offset offset) {
if (child != null)
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
}
}
@@ -662,7 +662,7 @@ class RenderOpacity extends RenderProxyBox {
return;
if (a == 255) {
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
return;
}
@@ -670,7 +670,7 @@ class RenderOpacity extends RenderProxyBox {
..color = new Color.fromARGB(a, 0, 0, 0)
..setTransferMode(sky.TransferMode.srcOver);
canvas.saveLayer(null, paint);
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
canvas.restore();
}
}
@@ -706,7 +706,7 @@ class RenderColorFilter extends RenderProxyBox {
Paint paint = new Paint()
..setColorFilter(new sky.ColorFilter.mode(_color, _transferMode));
canvas.saveLayer(null, paint);
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
canvas.restore();
}
}
@@ -719,7 +719,7 @@ class RenderClipRect extends RenderProxyBox {
if (child != null) {
canvas.save();
canvas.clipRect(offset & size);
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
canvas.restore();
}
}
@@ -758,7 +758,7 @@ class RenderClipRRect extends RenderProxyBox {
canvas.saveLayer(rect, new Paint());
sky.RRect rrect = new sky.RRect()..setRectXY(rect, xRadius, yRadius);
canvas.clipRRect(rrect);
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
canvas.restore();
}
}
@@ -774,7 +774,7 @@ class RenderClipOval extends RenderProxyBox {
Path path = new Path();
path.addOval(rect);
canvas.clipPath(path);
- child.paint(canvas, offset);
+ canvas.paintChild(child, offset.toPoint());
canvas.restore();
}
}
« no previous file with comments | « no previous file | sky/tests/examples/sector-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698