Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1208993009: Reland "Replace reduce-memory mode in idle notification with delayed clean-up GC." (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Replace reduce-memory mode in idle notification with delayed clean-up GC." This reverts commit 269918927a54cd1533ef4e3318dd76b3747762b5. This reverts commit 435b3c873ac3b58fb56a1b7292951810c93ceda5. The failing test is fixing in chromium. BUG=chromium:490559 LOG=NO TBR=hpayer@chromium.org Committed: https://crrev.com/a7f62edb7114604cc6a58f261923530299155f80 Cr-Commit-Position: refs/heads/master@{#29512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+659 lines, -630 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.h View 10 chunks +9 lines, -76 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 5 chunks +10 lines, -161 lines 0 comments Download
M src/heap/heap.h View 6 chunks +11 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +54 lines, -43 lines 0 comments Download
A src/heap/memory-reducer.h View 1 chunk +135 lines, -0 lines 0 comments Download
A src/heap/memory-reducer.cc View 1 chunk +140 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 11 chunks +54 lines, -345 lines 0 comments Download
A test/unittests/heap/memory-reducer-unittest.cc View 1 chunk +237 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993009/1
5 years, 5 months ago (2015-07-07 11:12:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 11:37:50 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 11:38:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7f62edb7114604cc6a58f261923530299155f80
Cr-Commit-Position: refs/heads/master@{#29512}

Powered by Google App Engine
This is Rietveld 408576698