Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: base/version.cc

Issue 1208983003: Use UintToString rather than IntToString in version.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@int_to_string_cleanup
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version.cc
diff --git a/base/version.cc b/base/version.cc
index 228dcb8aef20e4a33d9dd03269ceaa5195ba1a32..3677b731980beb8328a1b6b0633c791cd1dee44e 100644
--- a/base/version.cc
+++ b/base/version.cc
@@ -168,10 +168,10 @@ const std::string Version::GetString() const {
std::string version_str;
size_t count = components_.size();
for (size_t i = 0; i < count - 1; ++i) {
- version_str.append(IntToString(components_[i]));
+ version_str.append(UintToString(components_[i]));
version_str.append(".");
}
- version_str.append(IntToString(components_[count - 1]));
+ version_str.append(UintToString(components_[count - 1]));
return version_str;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698