Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: base/version.cc

Issue 1208983003: Use UintToString rather than IntToString in version.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@int_to_string_cleanup
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 DCHECK(IsValid()); 161 DCHECK(IsValid());
162 DCHECK(other.IsValid()); 162 DCHECK(other.IsValid());
163 return CompareVersionComponents(components_, other.components_); 163 return CompareVersionComponents(components_, other.components_);
164 } 164 }
165 165
166 const std::string Version::GetString() const { 166 const std::string Version::GetString() const {
167 DCHECK(IsValid()); 167 DCHECK(IsValid());
168 std::string version_str; 168 std::string version_str;
169 size_t count = components_.size(); 169 size_t count = components_.size();
170 for (size_t i = 0; i < count - 1; ++i) { 170 for (size_t i = 0; i < count - 1; ++i) {
171 version_str.append(IntToString(components_[i])); 171 version_str.append(UintToString(components_[i]));
172 version_str.append("."); 172 version_str.append(".");
173 } 173 }
174 version_str.append(IntToString(components_[count - 1])); 174 version_str.append(UintToString(components_[count - 1]));
175 return version_str; 175 return version_str;
176 } 176 }
177 177
178 } // namespace base 178 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698