Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1208983003: Use UintToString rather than IntToString in version.cc (Closed)

Created:
5 years, 5 months ago by Adam Rice
Modified:
5 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@int_to_string_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use UintToString rather than IntToString in version.cc Version components are unsigned integers, so UintToString() is the appropriate conversion function to use. BUG=505479 TEST=base_unittests Committed: https://crrev.com/0dd50573aeaf8a7c93da361e9049cde7efb7c6a3 Cr-Commit-Position: refs/heads/master@{#340523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/version.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
Adam Rice
5 years, 5 months ago (2015-07-03 11:54:36 UTC) #2
Adam Rice
-Nico (hiding) +rvargas for OWNERS.
5 years, 5 months ago (2015-07-24 14:04:34 UTC) #3
Adam Rice
-Nico (hiding) +rvargas for OWNERS. For real this time.
5 years, 5 months ago (2015-07-24 14:05:03 UTC) #5
rvargas (doing something else)
lgtm
5 years, 5 months ago (2015-07-24 21:56:10 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1212653005 Patch 1). Please resolve the dependency and ...
5 years, 5 months ago (2015-07-24 21:58:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1208983003/1
5 years, 4 months ago (2015-07-27 18:02:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 19:09:32 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 19:10:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dd50573aeaf8a7c93da361e9049cde7efb7c6a3
Cr-Commit-Position: refs/heads/master@{#340523}

Powered by Google App Engine
This is Rietveld 408576698