Move GN obj files to target-specific dirs

Move GN obj files to target-specific dirs

Previously GN would put object files in a similar place to GYP. They would go in a corresponding directory as the source file and would be prefixed with the target name for uniqueness.

Since GN target names are not unique, this doesn't work as well. Instead use a simpler scheme and put all the object files in a directory for each target.

This causes a few object file name collisions which this patch fixes in various ways:

- Renamed chrome/browser/ui/views/find_bar_host_interactive_uitest.cc to have "views" in the name (collided with chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc)

- Renamed chrome/browser/apps/speech_recognition_browsertest.cc to have "app" in the name (collided with chrome/browser/speech/speech_recognition_browsertest.cc).

- Renamed chrome/common/extensions/api/extension_api_unittest.cc to have "common" in the name (collided with chrome/browser/extensions/extension_api_unittest.cc which is actually a test harness with that name).

- Moved the extensions files that were in the chrome interactive UI tests and browser tests to source sets in the extensions directory. These are things that should be cleaned up and moved there anyway.

- Net has some messy duplication in quic files. I made a dummy target for them. Apparently each copy of this file (same code, different namespace) is supposed to match something different upstream and this should be fixed.

- Moved chrome/browser/chromeos unit tests to its own target.

- Renamed chrome/browser/favicon/favicon_helper to favicon_utils. It conflicted with chrome/browser/android/favicon_helper which has an actual class named "FaviconHelper.

- Renamed service.* and service_factory.* in chrome/browser/chromeos/launcher_search_provider to have a launcher_search_provider prefix to avoid collisions with the file_system_provider one.

- Added a "chromeos" prefix to chrome/browser/chromeos/first_run/first_run_browsertest.cc to avoid collisions with the one in browser/first_run.

- Added "chromeos" to chrome/browser/chromeos/preferences_browsertest.cc to avoid collision with browser/ui/webui/options.

- Rename "chrome/browser/chromeos/drive/test_util.*" to "drive_test_util.*". Update includes. Rename chrome/browser/chromeos/file_manager/drive_test_util* to mount_test_util to avoid colliding with above new file.

The deps->public_deps changes in components/policy and content/test is because those targets were used externally in a way that this patch uncovered.

Committed: https://crrev.com/39355da5ab86e662d701fcba8fef4e20921b38f0
Cr-Commit-Position: refs/heads/master@{#338408}

[brettw, 2015-06-30 20:21:33]

brettw@chromium.org changed reviewers:
+ thakis@chromium.org

[brettw, 2015-06-30 20:21:39]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-30 20:21:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/20001

[brettw, 2015-06-30 20:25:49]

Landing this will cause GN users to have duplicate .o files. Should we do a
landmine? I'm not sure if there are enough GN users to justify this, and it's
only some wasted disk space.

[Nico, 2015-06-30 20:38:47]

lgtm if the bots like it. I don't think this needs a landmine – deleting .cc
files has the same problem and this is kind of the same thing on a larger scale.
Nothing's going to break, it'll just take up some disk space as you say.

Hmm, do you think it'll get the bots close to their disk space limit? Probably
not?

cc rockot and rch/rtenneti for the extensions / quic stuff

https://codereview.chromium.org/1208963003/diff/20001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/1208963003/diff/20001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:26: 'chrome_browser_tests_extensions_sources': [
Can you file a bug on rockot for this? I doubt he's polling the codebase for
TODOs that people add on him. (Yes, there was a TODO before, but it has now
changed in scope)

https://codereview.chromium.org/1208963003/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1208963003/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:251: # The chrome_extensions_interactive_uitests target
should be delete and
"should be deleted"

https://codereview.chromium.org/1208963003/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:687: # The chrome_extensions_browsertests target should be
delete and this line
"should be deleted"

https://codereview.chromium.org/1208963003/diff/20001/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/1208963003/diff/20001/extensions/BUILD.gn#new...
extensions/BUILD.gn:7: import("//chrome/chrome_tests.gni")
eek!

https://codereview.chromium.org/1208963003/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1208963003/diff/20001/net/BUILD.gn#newcode1305
net/BUILD.gn:1305: # TODO(brettw) fix the confusingly-named files.
Can you file a bug with some of the quic folks (rch rtenneti I think) for this
too? I think they have some constraints here wrt mirroring this code between
chromium and google-internally

[commit-bot: I haz the power, 2015-06-30 20:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 20:46:54]

Dry run: Exceeded global retry quota

[brettw, 2015-06-30 21:11:53]

Review comments addressed.

[brettw, 2015-06-30 21:11:59]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-06-30 21:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps10017
(title: "review comments")

[commit-bot: I haz the power, 2015-06-30 21:14:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/10017

[commit-bot: I haz the power, 2015-06-30 21:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 21:20:28]

Exceeded global retry quota

[brettw, 2015-06-30 21:28:09]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-06-30 21:28:10]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps50001
(title: " ")

[commit-bot: I haz the power, 2015-06-30 21:29:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/50001

[commit-bot: I haz the power, 2015-06-30 21:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 21:53:18]

Exceeded global retry quota

[brettw, 2015-07-01 19:02:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-01 19:02:21]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps70001
(title: " ")

[commit-bot: I haz the power, 2015-07-01 19:02:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/70001

[commit-bot: I haz the power, 2015-07-01 20:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 20:00:41]

Dry run: Exceeded global retry quota

[brettw, 2015-07-07 17:07:29]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-07 17:07:29]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps90001
(title: " ")

[commit-bot: I haz the power, 2015-07-07 17:07:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/90001

[commit-bot: I haz the power, 2015-07-07 17:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 17:52:02]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-07-07 19:36:05]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-07 19:36:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps110001
(title: " ")

[commit-bot: I haz the power, 2015-07-07 19:36:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/110001

[commit-bot: I haz the power, 2015-07-07 19:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 19:54:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-07 21:49:06]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-07 21:49:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps130001
(title: " ")

[commit-bot: I haz the power, 2015-07-07 21:51:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/130001

[commit-bot: I haz the power, 2015-07-07 22:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 22:23:09]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

(exceeded global retry quota)

[brettw, 2015-07-07 22:23:34]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-07 22:23:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps110002
(title: " ")

[commit-bot: I haz the power, 2015-07-07 22:26:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/110002

[brettw, 2015-07-07 23:48:41]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-07 23:48:42]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps150001
(title: " ")

[commit-bot: I haz the power, 2015-07-07 23:54:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/150001

[commit-bot: I haz the power, 2015-07-08 02:49:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 02:49:30]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-08 06:20:34]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-08 06:20:34]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps170001
(title: " ")

[commit-bot: I haz the power, 2015-07-08 06:20:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/170001

[commit-bot: I haz the power, 2015-07-08 06:27:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 06:27:45]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-08 06:47:33]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-08 06:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps190001
(title: " ")

[commit-bot: I haz the power, 2015-07-08 06:47:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/190001

[commit-bot: I haz the power, 2015-07-08 08:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 08:12:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-08 16:01:30]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-07-08 16:01:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps200001
(title: " ")

[commit-bot: I haz the power, 2015-07-08 16:02:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/200001

[commit-bot: I haz the power, 2015-07-08 17:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 17:49:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-08 20:03:04]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-08 20:03:04]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps240001
(title: " ")

[commit-bot: I haz the power, 2015-07-08 20:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/240001

[commit-bot: I haz the power, 2015-07-08 20:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 20:25:01]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-08 21:17:57]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-08 21:17:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps260001
(title: " ")

[commit-bot: I haz the power, 2015-07-08 21:19:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/260001

[commit-bot: I haz the power, 2015-07-08 21:47:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 21:47:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-09 17:41:02]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 17:41:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps280001
(title: "y")

[commit-bot: I haz the power, 2015-07-09 17:41:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/280001

[commit-bot: I haz the power, 2015-07-09 17:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 17:47:48]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-07-09 17:53:10]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 17:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps300001
(title: "merge")

[commit-bot: I haz the power, 2015-07-09 17:54:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/300001

[commit-bot: I haz the power, 2015-07-09 18:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 18:34:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-09 19:27:01]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 19:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps320001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 19:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/320001

[commit-bot: I haz the power, 2015-07-09 19:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 19:56:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-09 20:07:42]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 20:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps340001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 20:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/340001

[commit-bot: I haz the power, 2015-07-09 20:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:37:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-09 22:03:31]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 22:03:32]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps360001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 22:06:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/360001

[Nico, 2015-07-09 22:13:41]

https://www.youtube.com/watch?v=Gf1WT8VEZxk

[commit-bot: I haz the power, 2015-07-09 22:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 22:39:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-09 23:17:02]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-09 23:17:03]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps380001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 23:18:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/380001

[commit-bot: I haz the power, 2015-07-10 01:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 01:24:10]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-10 05:58:41]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-10 05:58:41]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps400001
(title: " ")

[commit-bot: I haz the power, 2015-07-10 05:59:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/400001

[commit-bot: I haz the power, 2015-07-10 07:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 07:24:41]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-10 17:13:39]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-10 17:13:40]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps360002
(title: " ")

[commit-bot: I haz the power, 2015-07-10 17:14:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/360002

[commit-bot: I haz the power, 2015-07-10 19:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 19:42:41]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-10 23:07:55]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-10 23:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1208963003/#ps430001
(title: "\")

[commit-bot: I haz the power, 2015-07-10 23:09:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1208963003/430001

[commit-bot: I haz the power, 2015-07-11 00:21:04]

Committed patchset #25 (id:430001)

[commit-bot: I haz the power, 2015-07-11 00:22:10]

Patchset 25 (id:??) landed as
https://crrev.com/39355da5ab86e662d701fcba8fef4e20921b38f0
Cr-Commit-Position: refs/heads/master@{#338408}