[Sync] Add favicon datatype proto support

sync/protocol/proto_value_conversions.cc

Index: sync/protocol/proto_value_conversions.cc
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index fb5f568dbe89ab740472dd82d8dcf82fd9bc4807..78163962db814c54bd6edbfc229b4b422f94069e 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -21,6 +21,7 @@
 #include "sync/protocol/experiments_specifics.pb.h"
 #include "sync/protocol/extension_setting_specifics.pb.h"
 #include "sync/protocol/extension_specifics.pb.h"
+#include "sync/protocol/favicon_specifics.pb.h"
 #include "sync/protocol/history_delete_directive_specifics.pb.h"
 #include "sync/protocol/nigori_specifics.pb.h"
 #include "sync/protocol/password_specifics.pb.h"
@@ -355,6 +356,25 @@ DictionaryValue* ExtensionSpecificsToValue(
   return value;
 }
 
+DictionaryValue* FaviconDataToValue(

[pkotwicz, 2013/02/07 02:15:47]

Nit: put this method into an anonymous namespace?

+    const sync_pb::FaviconData& proto) {
+  DictionaryValue* value = new DictionaryValue();
+  SET_BYTES(favicon);
+  SET_ENUM(icon_type, GetIconTypeString);
+  SET_INT32(width);
+  return value;
+}
+
+DictionaryValue* FaviconSpecificsToValue(
+    const sync_pb::FaviconSpecifics& proto) {
+  DictionaryValue* value = new DictionaryValue();
+  SET_STR(favicon_source);
+  SET_REP(favicons, FaviconDataToValue);
+  SET_INT64(last_visit_time_ms);
+  SET_BOOL(is_bookmarked);
+  return value;
+}
+
 base::DictionaryValue* HistoryDeleteDirectiveSpecificsToValue(
     const sync_pb::HistoryDeleteDirectiveSpecifics& proto) {
   DictionaryValue* value = new DictionaryValue();