[Sync] Add favicon datatype proto support

sync/protocol/proto_value_conversions.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Keep this file in sync with the .proto files in this directory.
 
 #include "sync/protocol/proto_value_conversions.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/values.h"
 #include "sync/protocol/app_notification_specifics.pb.h"
 #include "sync/protocol/app_setting_specifics.pb.h"
 #include "sync/protocol/app_specifics.pb.h"
 #include "sync/protocol/autofill_specifics.pb.h"
 #include "sync/protocol/bookmark_specifics.pb.h"
 #include "sync/protocol/dictionary_specifics.pb.h"
 #include "sync/protocol/encryption.pb.h"
 #include "sync/protocol/experiments_specifics.pb.h"
 #include "sync/protocol/extension_setting_specifics.pb.h"
 #include "sync/protocol/extension_specifics.pb.h"
+#include "sync/protocol/favicon_specifics.pb.h"
 #include "sync/protocol/history_delete_directive_specifics.pb.h"
 #include "sync/protocol/nigori_specifics.pb.h"
 #include "sync/protocol/password_specifics.pb.h"
 #include "sync/protocol/preference_specifics.pb.h"
 #include "sync/protocol/priority_preference_specifics.pb.h"
 #include "sync/protocol/proto_enum_conversions.h"
 #include "sync/protocol/search_engine_specifics.pb.h"
 #include "sync/protocol/session_specifics.pb.h"
 #include "sync/protocol/sync.pb.h"
 #include "sync/protocol/synced_notification_specifics.pb.h"
@@ skipping 314 matching lines @@
   DictionaryValue* value = new DictionaryValue();
   SET_STR(id);
   SET_STR(version);
   SET_STR(update_url);
   SET_BOOL(enabled);
   SET_BOOL(incognito_enabled);
   SET_STR(name);
   return value;
 }
 
+DictionaryValue* FaviconDataToValue(

[pkotwicz, 2013/02/07 02:15:47]

Nit: put this method into an anonymous namespace?

+    const sync_pb::FaviconData& proto) {
+  DictionaryValue* value = new DictionaryValue();
+  SET_BYTES(favicon);
+  SET_ENUM(icon_type, GetIconTypeString);
+  SET_INT32(width);
+  return value;
+}
+
+DictionaryValue* FaviconSpecificsToValue(
+    const sync_pb::FaviconSpecifics& proto) {
+  DictionaryValue* value = new DictionaryValue();
+  SET_STR(favicon_source);
+  SET_REP(favicons, FaviconDataToValue);
+  SET_INT64(last_visit_time_ms);
+  SET_BOOL(is_bookmarked);
+  return value;
+}
+
 base::DictionaryValue* HistoryDeleteDirectiveSpecificsToValue(
     const sync_pb::HistoryDeleteDirectiveSpecifics& proto) {
   DictionaryValue* value = new DictionaryValue();
   SET(global_id_directive, GlobalIdDirectiveToValue);
   SET(time_range_directive, TimeRangeDirectiveToValue);
   return value;
 }
 
 DictionaryValue* NigoriSpecificsToValue(
     const sync_pb::NigoriSpecifics& proto) {
@@ skipping 378 matching lines @@
 #undef SET_BYTES
 #undef SET_INT32
 #undef SET_INT64
 #undef SET_INT64_REP
 #undef SET_STR
 #undef SET_STR_REP
 
 #undef SET_FIELD
 
 }  // namespace syncer