Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: pkg/unittest/lib/html_individual_config.dart

Issue 12089081: Fix Safari "multitest" failure. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/html_individual_config.dart
diff --git a/pkg/unittest/lib/html_individual_config.dart b/pkg/unittest/lib/html_individual_config.dart
index 2de4ed22d206d2ae144afb67bc05714b7fa3aa06..9c26e11c6decc14f7a7c61a967d3b6be98114cb0 100644
--- a/pkg/unittest/lib/html_individual_config.dart
+++ b/pkg/unittest/lib/html_individual_config.dart
@@ -24,11 +24,16 @@ class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration {
HtmlIndividualConfiguration(isLayoutTest): super(isLayoutTest);
void onStart() {
- var testGroupName = window.location.hash;
- if (testGroupName != '') {
+ var testGroupName = window.location.search;
+ var groupVar = '&group=';
kustermann 2013/01/31 00:07:01 I'd prefer something like: for (var getParameter i
+ if (testGroupName != '' && testGroupName.contains(groupVar)) {
try {
- testGroupName = testGroupName.substring(1); // cut off the #
- unittest.filterTests('^$testGroupName');
+ testGroupName = testGroupName.substring(
+ testGroupName.indexOf(groupVar) + groupVar.length);
+ var endIndex = testGroupName.indexOf('&');
+ testGroupName = testGroupName.substring(0,
+ endIndex == -1 ? testGroupName.length : endIndex);
+ unittest.filterTests('^$testGroupName${unittest.groupSep}');
} catch (e) {
print('tried to match "$testGroupName"');
print('NO_SUCH_TEST');
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698