Issue 12089080: Remove restriction on paths in 'deps_file' setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12089080: Remove restriction on paths in 'deps_file' setting. (Closed)

Created:
7 years, 10 months ago by Michael Moss

Modified:
7 years, 10 months ago

Reviewers:
M-A Ruel, mmoss

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, szager1

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Remove restriction on paths in 'deps_file' setting. BUG=172935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179741

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	gclient.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmoss

I've tested a sync with deps_file pointing to a git repo subdir, and everything looks ...

7 years, 10 months ago (2013-01-30 23:09:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/12089080/1

7 years, 10 months ago (2013-01-30 23:45:02 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-01-30 23:48:10 UTC) #4

Presubmit check for 12089080-1 failed and returned exit status 1.

************* Module drover
W0311:528,0: Bad indentation. Found 6 spaces, expected 4
W0311:529,0: Bad indentation. Found 6 spaces, expected 4
Running presubmit commit checks ...
Running pylint on 51 files.
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 186.7s to calculate.

Expand Messages | Collapse Messages