Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: gclient.py

Issue 12089080: Remove restriction on paths in 'deps_file' setting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
===================================================================
--- gclient.py (revision 179713)
+++ gclient.py (working copy)
@@ -197,9 +197,9 @@
raise gclient_utils.Error(
('dependency url must be either a string, None, '
'File() or From() instead of %s') % self._url.__class__.__name__)
- if '/' in self._deps_file or '\\' in self._deps_file:
- raise gclient_utils.Error('deps_file name must not be a path, just a '
- 'filename. %s' % self._deps_file)
+ # Make any deps_file path platform-appropriate.
+ for sep in ['/', '\\']:
+ self._deps_file = self._deps_file.replace(sep, os.sep)
@property
def deps_file(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698