runtime/vm/object.cc - Issue 12089049: Do not add smis to the store buffer when cloning objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 12089049: Do not add smis to the store buffer when cloning objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

===================================================================

--- runtime/vm/object.cc (revision 17755)

+++ runtime/vm/object.cc (working copy)

@@ -1307,7 +1307,7 @@

}

void VisitPointers(RawObject** first, RawObject** last) {

for (RawObject** curr = first; curr <= last; ++curr) {

- if ((*curr)->IsNewObject()) {

+ if ((*curr)->IsHeapObject() && (*curr)->IsNewObject()) {

Ivan Posva 2013/01/29 17:55:09 RawObject* raw_obj = *curr; if (raw_obj->IsHeapObj

Florian Schneider 2013/01/29 20:04:19 Done.

uword ptr = reinterpret_cast<uword>(curr);

isolate()->store_buffer()->AddPointer(ptr);

}

« no previous file with comments | « no previous file | runtime/vm/raw_object.h » ('j') | no next file with comments »