Do not add smis to the store buffer when cloning objects.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 1282 matching lines @@
     UNREACHABLE();
   }
   NoGCScope no_gc;
   InitializeObject(address, cls_id, size);
   RawObject* raw_obj = reinterpret_cast<RawObject*>(address + kHeapObjectTag);
   ASSERT(cls_id == RawObject::ClassIdTag::decode(raw_obj->ptr()->tags_));
   return raw_obj;
 }
 
 
 class StoreBufferObjectPointerVisitor : public ObjectPointerVisitor {

[Ivan Posva, 2013/01/29 17:55:09]

How about renaming this to StoreBufferUpdateVisitor?

[Florian Schneider, 2013/01/29 20:04:19]

Done.

  public:
   explicit StoreBufferObjectPointerVisitor(Isolate* isolate) :
       ObjectPointerVisitor(isolate) {
   }
   void VisitPointers(RawObject** first, RawObject** last) {
     for (RawObject** curr = first; curr <= last; ++curr) {
-      if ((*curr)->IsNewObject()) {
+      if ((*curr)->IsHeapObject() && (*curr)->IsNewObject()) {

[Ivan Posva, 2013/01/29 17:55:09]

RawObject* raw_obj = *curr;
if (raw_obj->IsHeapObject() && raw_obj->IsNewObject()) {

[Florian Schneider, 2013/01/29 20:04:19]

Done.

         uword ptr = reinterpret_cast<uword>(curr);
         isolate()->store_buffer()->AddPointer(ptr);
       }
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(StoreBufferObjectPointerVisitor);
 };
 
@@ skipping 11483 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart