Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 12089042: Merge 139616 (Closed)

Created:
7 years, 10 months ago by vsevik
Modified:
7 years, 10 months ago
Reviewers:
vsevik
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139616 > Web Inspector: Audit Tool's False Positive on Set-Cookie header > https://bugs.webkit.org/show_bug.cgi?id=106794 > > Reviewed by Pavel Feldman. > > Source/WebCore: > > Header value is now returned as undefined if there is no such header as it was before regression. > > Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html > > * inspector/front-end/AuditRules.js: > (WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers. > * inspector/front-end/NetworkRequest.js: > (WebInspector.NetworkRequest.prototype._headerValue): > > LayoutTests: > > * http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png. > * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added. > * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added. > TBR=vsevik@chromium.org BUG=169771 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
D LayoutTests/inspector/audits/resources/abe.png View Binary file 0 comments Download
M Source/WebCore/inspector/front-end/AuditRules.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/NetworkRequest.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vsevik
7 years, 10 months ago (2013-01-29 08:29:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698