Don't use ReversedListView from outside core and collection.

Don't use ReversedListView from outside core and collection.

Committed: https://code.google.com/p/dart/source/detail?r=17772

[floitsch, 2013-01-28 21:31:32]

ReversedListView lives in collection-dev and is hence only visible to core and
collection.

[Lasse Reichstein Nielsen, 2013-01-29 08:11:22]

Since other libraries imports collection-dev too (because I told them to when I
used the class), I don't see the need for this change.
These are libraries that implement their own collections, it's reasonable for
them to import collection-dev.

If you don't want the libraries to import collection-dev, do remove the imports
too.

I see no need for this change, but if you want it then lgtm.

https://codereview.chromium.org/12089023/diff/1/samples/swarm/swarm_ui_lib/ob...
File samples/swarm/swarm_ui_lib/observable/observable.dart (right):

https://codereview.chromium.org/12089023/diff/1/samples/swarm/swarm_ui_lib/ob...
samples/swarm/swarm_ui_lib/observable/observable.dart:8: import
'dart:collection-dev';
But collections-dev is imported here, so why shouldn't it work?

https://codereview.chromium.org/12089023/diff/1/samples/swarm/swarm_ui_lib/ob...
samples/swarm/swarm_ui_lib/observable/observable.dart:166: List<T> get reversed
=> _internal.reversed;
That works, but only because you can't assign through the reversed list.

https://codereview.chromium.org/12089023/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_array.dart (right):

https://codereview.chromium.org/12089023/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_array.dart:225: List<E> get
reversed => IterableMixinWorkaround.reversed(this);
The interceptor.dart library imports collections-dev, so again this is not
necessary.

https://codereview.chromium.org/12089023/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_array.dart:225: List<E> get
reversed => IterableMixinWorkaround.reversed(this);
Should't it be ".reversedList"?

https://codereview.chromium.org/12089023/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/12089023/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Element.darttemplate:141: return
IterableMixinWorkaround.reversedList(this);
html library imports collections-dev.

[floitsch, 2013-01-29 15:41:07]

https://codereview.chromium.org/12089023/diff/1/samples/swarm/swarm_ui_lib/ob...
File samples/swarm/swarm_ui_lib/observable/observable.dart (right):

https://codereview.chromium.org/12089023/diff/1/samples/swarm/swarm_ui_lib/ob...
samples/swarm/swarm_ui_lib/observable/observable.dart:8: import
'dart:collection-dev';
On 2013/01/29 08:11:22, Lasse Reichstein Nielsen wrote:
> But collections-dev is imported here, so why shouldn't it work?

It shouldn't. I will prepare to remove it.

https://codereview.chromium.org/12089023/diff/1/samples/swarm/swarm_ui_lib/ob...
samples/swarm/swarm_ui_lib/observable/observable.dart:166: List<T> get reversed
=> _internal.reversed;
On 2013/01/29 08:11:22, Lasse Reichstein Nielsen wrote:
> That works, but only because you can't assign through the reversed list.

Should be ok then. If we change that behavior, we shouldn't forget to change it
here. Even if we forget, it should not be a big problem, since Swarm doesn't use
"reversed".

https://codereview.chromium.org/12089023/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_array.dart (right):

https://codereview.chromium.org/12089023/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_array.dart:225: List<E> get
reversed => IterableMixinWorkaround.reversed(this);
On 2013/01/29 08:11:22, Lasse Reichstein Nielsen wrote:
> The interceptor.dart library imports collections-dev, so again this is not
> necessary.

It shouldn't.

https://codereview.chromium.org/12089023/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_array.dart:225: List<E> get
reversed => IterableMixinWorkaround.reversed(this);
On 2013/01/29 08:11:22, Lasse Reichstein Nielsen wrote:
> Should't it be ".reversedList"?

Done.