Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 12089023: Don't use ReversedListView from outside core and collection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix dart2js. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 2c7dd638ec7e9a08421cb56160575b2a0aed8e26..781fac53abcc84c4a3a6426b3688dc2493ba356a 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -7870,8 +7870,9 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List<DomMimeT
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<DomMimeType> get reversed =>
- new ReversedListView<DomMimeType>(this, 0, null);
+ List<DomMimeType> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(DomMimeType a, DomMimeType b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -8128,8 +8129,9 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List<DomPlugin>
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<DomPlugin> get reversed =>
- new ReversedListView<DomPlugin>(this, 0, null);
+ List<DomPlugin> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(DomPlugin a, DomPlugin b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -8509,8 +8511,9 @@ class DomStringList extends NativeFieldWrapperClass1 implements List<String> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<String> get reversed =>
- new ReversedListView<String>(this, 0, null);
+ List<String> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(String a, String b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -8795,8 +8798,9 @@ class _ChildrenElementList implements List {
}
}
- List<Element> get reversed =>
- new ReversedListView<Element>(this, 0, null);
+ List<Element> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('TODO(jacobr): should we impl?');
@@ -9020,8 +9024,9 @@ class _FrozenElementList implements List {
throw new UnsupportedError('');
}
- List<Element> get reversed =>
- new ReversedListView<Element>(this, 0, null);
+ List<Element> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('');
@@ -11422,8 +11427,9 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<File> get reversed =>
- new ReversedListView<File>(this, 0, null);
+ List<File> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(File a, File b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -12070,8 +12076,9 @@ class Float32Array extends ArrayBufferView implements List<num> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<num> get reversed =>
- new ReversedListView<num>(this, 0, null);
+ List<num> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(num a, num b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -12294,8 +12301,9 @@ class Float64Array extends ArrayBufferView implements List<num> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<num> get reversed =>
- new ReversedListView<num>(this, 0, null);
+ List<num> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(num a, num b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -12870,8 +12878,9 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Node> get reversed =>
- new ReversedListView<Node>(this, 0, null);
+ List<Node> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -13074,8 +13083,9 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Node> get reversed =>
- new ReversedListView<Node>(this, 0, null);
+ List<Node> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -15187,8 +15197,9 @@ class Int16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -15411,8 +15422,9 @@ class Int32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -15635,8 +15647,9 @@ class Int8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -18202,8 +18215,9 @@ class NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Node> get reversed =>
- new ReversedListView<Node>(this, 0, null);
+ List<Node> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -18650,8 +18664,9 @@ class _ChildNodeListLazy implements List {
return this[index];
}
- List<Node> get reversed =>
- new ReversedListView<Node>(this, 0, null);
+ List<Node> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
// TODO(jacobr): this could be implemented for child node lists.
// The exception we throw here is misleading.
@@ -19048,8 +19063,9 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Node> get reversed =>
- new ReversedListView<Node>(this, 0, null);
+ List<Node> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Node a, Node b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -21748,8 +21764,9 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<SourceBuffer> get reversed =>
- new ReversedListView<SourceBuffer>(this, 0, null);
+ List<SourceBuffer> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(SourceBuffer a, SourceBuffer b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -22049,8 +22066,9 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<SpeechGrammar> get reversed =>
- new ReversedListView<SpeechGrammar>(this, 0, null);
+ List<SpeechGrammar> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(SpeechGrammar a, SpeechGrammar b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -22740,8 +22758,9 @@ class SqlResultSetRowList extends NativeFieldWrapperClass1 implements List<Map>
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Map> get reversed =>
- new ReversedListView<Map>(this, 0, null);
+ List<Map> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Map a, Map b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -24052,8 +24071,9 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<TextTrackCue> get reversed =>
- new ReversedListView<TextTrackCue>(this, 0, null);
+ List<TextTrackCue> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(TextTrackCue a, TextTrackCue b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -24262,8 +24282,9 @@ class TextTrackList extends EventTarget implements List<TextTrack> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<TextTrack> get reversed =>
- new ReversedListView<TextTrack>(this, 0, null);
+ List<TextTrack> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(TextTrack a, TextTrack b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -24651,8 +24672,9 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Touch> get reversed =>
- new ReversedListView<Touch>(this, 0, null);
+ List<Touch> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Touch a, Touch b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -25125,8 +25147,9 @@ class Uint16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -25349,8 +25372,9 @@ class Uint32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -25573,8 +25597,9 @@ class Uint8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -25795,8 +25820,9 @@ class Uint8ClampedArray extends Uint8Array implements List<int> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<int> get reversed =>
- new ReversedListView<int>(this, 0, null);
+ List<int> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(int a, int b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -29624,8 +29650,9 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<ClientRec
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<ClientRect> get reversed =>
- new ReversedListView<ClientRect>(this, 0, null);
+ List<ClientRect> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(ClientRect a, ClientRect b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -29820,8 +29847,9 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List<CssRule> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<CssRule> get reversed =>
- new ReversedListView<CssRule>(this, 0, null);
+ List<CssRule> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(CssRule a, CssRule b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -30016,8 +30044,9 @@ class _CssValueList extends CssValue implements List<CssValue> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<CssValue> get reversed =>
- new ReversedListView<CssValue>(this, 0, null);
+ List<CssValue> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(CssValue a, CssValue b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -30362,8 +30391,9 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Entry> get reversed =>
- new ReversedListView<Entry>(this, 0, null);
+ List<Entry> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Entry a, Entry b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -30558,8 +30588,9 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<EntrySync
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<EntrySync> get reversed =>
- new ReversedListView<EntrySync>(this, 0, null);
+ List<EntrySync> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(EntrySync a, EntrySync b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -30845,8 +30876,9 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<Gamepad> get reversed =>
- new ReversedListView<Gamepad>(this, 0, null);
+ List<Gamepad> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(Gamepad a, Gamepad b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -31054,8 +31086,9 @@ class _MediaStreamList extends NativeFieldWrapperClass1 implements List<MediaStr
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<MediaStream> get reversed =>
- new ReversedListView<MediaStream>(this, 0, null);
+ List<MediaStream> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(MediaStream a, MediaStream b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -31250,8 +31283,9 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<SpeechInputResult> get reversed =>
- new ReversedListView<SpeechInputResult>(this, 0, null);
+ List<SpeechInputResult> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(SpeechInputResult a, SpeechInputResult b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -31446,8 +31480,9 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<SpeechRecognitionResult> get reversed =>
- new ReversedListView<SpeechRecognitionResult>(this, 0, null);
+ List<SpeechRecognitionResult> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(SpeechRecognitionResult a, SpeechRecognitionResult b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
@@ -31642,8 +31677,9 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee
throw new UnsupportedError("Cannot clear immutable List.");
}
- List<StyleSheet> get reversed =>
- new ReversedListView<StyleSheet>(this, 0, null);
+ List<StyleSheet> get reversed {
+ return IterableMixinWorkaround.reversedList(this);
+ }
void sort([int compare(StyleSheet a, StyleSheet b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698