Issue 12088107: Revert 180117, it broke all telemetry tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12088107: Revert 180117, it broke all telemetry tests. (Closed)

Created:
7 years, 10 months ago by marja

Modified:
7 years, 10 months ago

Reviewers:
marja

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 180117, it broke all telemetry tests. Going to commit a fixed version soon. > Telemetry: add a metadata layer between page set and .wpr. > > The metadata file describes which pages in the page set are > backed by which .wpr files. This allows us to update individual > pages in the page set. > > BUG=155660 > NOTRY=true > > > Review URL: https://chromiumcodereview.appspot.com/11881051 TBR=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180131

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -368 lines)			Patch
M	tools/perf/page_sets/2012Q3.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/jsgamebench.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/key_desktop_sites.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/kraken.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/robohornetpro.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/top_25.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/tough_canvas_cases.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/multi_page_benchmark_unittest.py	View	3 chunks	+4 lines, -22 lines	0 comments	Download
M	tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page.py	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page_runner.py	View	2 chunks	+21 lines, -27 lines	0 comments	Download
M	tools/telemetry/telemetry/page_runner_unittest.py	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page_set.py	View	3 chunks	+6 lines, -19 lines	0 comments	Download
D	tools/telemetry/telemetry/page_set_archive_info.py	View	1 chunk	+0 lines, -124 lines	0 comments	Download
D	tools/telemetry/telemetry/page_set_archive_info_unittest.py	View	1 chunk	+0 lines, -101 lines	0 comments	Download
M	tools/telemetry/telemetry/page_set_unittest.py	View	2 chunks	+6 lines, -25 lines	0 comments	Download
M	tools/telemetry/telemetry/page_unittest.py	View	4 chunks	+3 lines, -7 lines	0 comments	Download
M	tools/telemetry/telemetry/record_wpr.py	View	3 chunks	+2 lines, -21 lines	0 comments	Download
M	tools/telemetry/telemetry/scrolling_action_unittest.py	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages