tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py - Issue 12088107: Revert 180117, it broke all telemetry tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py

Issue 12088107: Revert 180117, it broke all telemetry tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py

===================================================================

--- tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py (revision 180130)

+++ tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py (working copy)

@@ -21,9 +21,9 @@

def CreatePageSet(self, test_filename):

base_dir = os.path.dirname(__file__)

- ps = page_set.PageSet(file_path=os.path.join(base_dir, 'foo.json'))

- page = page_module.Page(test_filename, ps, base_dir=base_dir)

+ page = page_module.Page(test_filename, base_dir=base_dir)

setattr(page, 'smoothness', {'action': 'scrolling_action'})

+ ps = page_set.PageSet(base_dir=base_dir)

ps.pages.append(page)

return ps